Cosmetic changes to nnet3 printed output#2338
Merged
danpovey merged 3 commits intokaldi-asr:masterfrom Apr 6, 2018
Merged
Conversation
Contributor
|
Thanks-- I assume you have tested this? |
Contributor
Author
|
I've tested for 3-4 epochs for each script besides train_raw_rnn.py (as I'm not really familiar with the segmentation scripts) and for full training for train_rnn.py. Considering how the code works, the only problem it could create is the absence of logging information if there are other python training scripts calling the frame-level common.py besides the four I've changed, but as far as I know there shouldn't be other. |
Contributor
|
OK, sounds good enough. Merging. Thanks! |
LvHang
pushed a commit
to LvHang/kaldi
that referenced
this pull request
Apr 14, 2018
…ut (kaldi-asr#2338) Conflicts: egs/wsj/s5/steps/libs/nnet3/train/frame_level_objf/common.py egs/wsj/s5/steps/nnet3/train_raw_dnn.py
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As for #2003, the logging code was made identical to the chain logging code.