Skip to content

Bug fix: oscillating cluster threshold in agglomerative-cluster #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danpovey merged 2 commits into from
Apr 3, 2018
Merged

Bug fix: oscillating cluster threshold in agglomerative-cluster #2333

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e999f7
fixed oscillating threshold bug in agglomerative-cluster
mmaciej2 Apr 3, 2018
1a61529
fixed typo
mmaciej2 Apr 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/ivectorbin/agglomerative-cluster.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ int main(int argc, char *argv[]) {
" is less than this threshold.");
po.Register("read-costs", &read_costs, "If true, the first"
" argument is interpreted as a matrix of costs rather than a"
"similarity matrix.");
" similarity matrix.");

po.Read(argc, argv);

Expand All @@ -75,6 +75,8 @@ int main(int argc, char *argv[]) {
RandomAccessInt32Reader reco2num_spk_reader(reco2num_spk_rspecifier);
Int32Writer label_writer(label_wspecifier);

if (!read_costs)
threshold = -threshold;
for (; !scores_reader.Done(); scores_reader.Next()) {
std::string reco = scores_reader.Key();
Matrix<BaseFloat> costs = scores_reader.Value();
Expand All @@ -84,7 +86,6 @@ int main(int argc, char *argv[]) {
// clustering code requires.
if (!read_costs)
costs.Scale(-1);
threshold = -threshold;
std::vector<std::string> uttlist = reco2utt_reader.Value(reco);
std::vector<int32> spk_ids;
if (reco2num_spk_rspecifier.size()) {
Expand Down