Bug fix: oscillating cluster threshold in agglomerative-cluster#2333
Merged
danpovey merged 2 commits intokaldi-asr:masterfrom Apr 3, 2018
Merged
Bug fix: oscillating cluster threshold in agglomerative-cluster#2333danpovey merged 2 commits intokaldi-asr:masterfrom
danpovey merged 2 commits intokaldi-asr:masterfrom
Conversation
Contributor
|
Merging. Please comment whether this would have affected any checked-in recipes. |
Contributor
Author
|
This should not affect any checked-in recipes, as they tune the threshold as part of the recipe. It's possible that the error rate will decrease slightly, but using PLDA scoring should result in an optimal threshold of 0 in theory; and, a threshold of 0 would be unaffected by this bug, so the effect should be minimal. I will verify that there is no appreciable performance difference on the CallHome recipe, but this bug should really only affect scoring methods that are not "centered" around 0, which we do not currently use. |
LvHang
pushed a commit
to LvHang/kaldi
that referenced
this pull request
Apr 14, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in agglomerative-cluster.cc that would cause the threshold used for clustering to oscillate between positive and negative per recording.