Skip to content

test(dynamicpathdetector): isolate analyzer per subtest in TestAnalyz… #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
entlein merged 1 commit into from
Apr 29, 2026
Merged

test(dynamicpathdetector): isolate analyzer per subtest in TestAnalyz… #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions pkg/registry/file/dynamicpathdetector/tests/analyze_endpoints_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ import (
)

func TestAnalyzeEndpoints(t *testing.T) {
analyzer := dynamicpathdetector.NewPathAnalyzerWithConfigs(dynamicpathdetector.EndpointDynamicThreshold, nil)

tests := []struct {
name string
input []types.HTTPEndpoint
Expand Down Expand Up @@ -94,18 +92,13 @@ func TestAnalyzeEndpoints(t *testing.T) {
Methods: []string{"POST"},
},
},
// NOTE: the analyzer trie persists across subtests in this
// table (analyzer is created outside the t.Run loop), so
// /users/\u22ef/posts/\u22ef has already been observed enough times
// for the :80 entry's trailing segment to be dynamicized;
// the :8770 path is fresh in the trie so it stays concrete.
expected: []types.HTTPEndpoint{
{
Endpoint: ":0/users/123/posts/\u22ef",
Methods: []string{"GET"},
},
{
Endpoint: ":80/users/\u22ef/posts/\u22ef",
Endpoint: ":80/users/\u22ef/posts/101",
Methods: []string{"POST"},
},
{
Expand Down Expand Up @@ -175,6 +168,7 @@ func TestAnalyzeEndpoints(t *testing.T) {

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
analyzer := dynamicpathdetector.NewPathAnalyzerWithConfigs(dynamicpathdetector.EndpointDynamicThreshold, nil)
result := dynamicpathdetector.AnalyzeEndpoints(&tt.input, analyzer)
ja := jsonassert.New(t)
for i := range result {
Expand Down
Loading