test(dynamicpathdetector): isolate analyzer per subtest in TestAnalyz…#22
Merged
Merged
Conversation
…eEndpoints The table-driven TestAnalyzeEndpoints shared one PathAnalyzer across all subtests. Because AnalyzeEndpoints mutates the analyzer trie, expected outputs of later subtests were silently coupled to the trie state left by earlier ones — running any case in isolation would have exercised a different state and could mask regressions. Move the analyzer construction inside the t.Run loop so each subtest starts from a fresh trie. Restore the 'Test with 0 port' expected output to its order-independent shape (the :80 entry stays as :80/users/⋯/posts/101 because no other input reaches the trie's dynamic-collapse threshold within that case). Addresses CodeRabbit review on #21.
Author
|
ok, lets retest |
|
Summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eEndpoints
The table-driven TestAnalyzeEndpoints shared one PathAnalyzer across all subtests. Because AnalyzeEndpoints mutates the analyzer trie, expected outputs of later subtests were silently coupled to the trie state left by earlier ones — running any case in isolation would have exercised a different state and could mask regressions.
Move the analyzer construction inside the t.Run loop so each subtest starts from a fresh trie. Restore the 'Test with 0 port' expected output to its order-independent shape (the :80 entry stays as :80/users/⋯/posts/101 because no other input reaches the trie's dynamic-collapse threshold within that case).
Addresses CodeRabbit review on #21.
Sorry, we do not accept changes directly against this repository. Please see
CONTRIBUTING.md for information on where and how to contribute instead.