Skip to content

Fix releasing Dart iOS package #3680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csukuangfj merged 2 commits into from
Jun 15, 2026
Merged

Fix releasing Dart iOS package #3680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19c826f
Fix releasing Dart iOS package
csukuangfj Jun 15, 2026
54ab410
Small fixes
csukuangfj Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build-ios-shared.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ install_name_tool \
sherpa_onnx

chmod +x sherpa_onnx
strip -x sherpa_onnx
popd

pushd ios-arm64_x86_64-simulator
Expand All @@ -214,6 +215,7 @@ install_name_tool \
sherpa_onnx

chmod +x sherpa_onnx
strip -x sherpa_onnx
popd

for d in ios-arm64_x86_64-simulator ios-arm64; do
Expand Down
2 changes: 1 addition & 1 deletion sherpa-onnx/csrc/offline-catt-model.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class OfflineCATTModel::Impl {
return std::move(ans[0]);
}

OrtAllocator *Allocator() const { return allocator_; }
OrtAllocator *Allocator() { return allocator_; }

@gemini-code-assist gemini-code-assist Bot Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To preserve the const-correctness of the Impl::Allocator() method, you can mark the allocator_ member variable as mutable (at line 118). This allows you to keep Allocator() const as const without compilation errors, maintaining consistency with OfflineCATTModel::Allocator() const.


private:
void InitEncoder() {
Expand Down
Loading