Fix releasing Dart iOS package - #3680
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo unrelated fixes: ChangesiOS Framework Symbol Stripping
CATT Model Allocator const Removal
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds symbol stripping (strip -x) to the iOS shared library build script and removes the const qualifier from the Allocator() method in OfflineCATTModel::Impl. Feedback suggests maintaining const-correctness for Allocator() by marking the allocator_ member variable as mutable instead of removing the const qualifier.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } | ||
|
|
||
| OrtAllocator *Allocator() const { return allocator_; } | ||
| OrtAllocator *Allocator() { return allocator_; } |
There was a problem hiding this comment.
Summary by CodeRabbit