Release v1.12.37 - #3496
Merged
Merged
Release v1.12.37#3496
Conversation
csukuangfj
marked this pull request as ready for review
April 10, 2026 16:56
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (66)
📝 WalkthroughWalkthroughThe PR updates the project version from 1.12.36 to 1.12.37 across the entire repository, including CMake configuration, Android Gradle files, iOS build scripts, Dart/Flutter package manifests, Rust crates, Python setuptools, HarmonyOS packages, and version metadata files. A changelog entry documenting dependency and documentation updates is added. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dosubot
Bot
added
the
size:M
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request increments the project version from 1.12.36 to 1.12.37 across a wide range of files, including build configurations for Android, iOS, HarmonyOS, Rust, and Flutter. It also updates the changelog, release scripts, and internal versioning metadata. A review comment suggests a correction in the new-release.sh script to use a plain version string for the sed replacement variable, avoiding unnecessary escaping that could cause portability issues.
Comment on lines
+8
to
+9
| old_version="1\.12\.36" | ||
| new_version="1\.12\.37" |
There was a problem hiding this comment.
The new_version variable contains escaped dots (e.g., 1\.12\.37). While escaping dots is necessary for the sed search pattern (regex) to match literal dots, it is unnecessary and potentially non-portable in the replacement string. Some sed implementations might preserve the backslashes literally in the output files. It is recommended to use a plain version string for the replacement.
Suggested change
| old_version="1\.12\.36" | |
| new_version="1\.12\.37" | |
| old_version="1\.12\.36" | |
| new_version="1.12.37" |
This was referenced Apr 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit