Release v1.12.32 - #3387
Merged
Merged
Release v1.12.32#3387
Conversation
dosubot
Bot
added
the
size:M
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (64)
📝 WalkthroughWalkthroughThis pull request bumps the sherpa-onnx project version from 1.12.31 to 1.12.32. The changes update version numbers, timestamps, and Git metadata across build configuration files, package manifests, and platform-specific files spanning Android, Dart, Flutter, Rust, Python, Node.js, iOS, macOS, and HarmonyOS ecosystems. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on releasing version 1.12.32 of the sherpa-onnx project. It involves updating version numbers and dependencies across multiple platforms and examples to ensure consistency and incorporate the latest changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Release bump to v1.12.32 across the repo, updating package manifests and documentation references to the new version.
Changes:
- Bump version numbers from
1.12.31→1.12.32across Rust, Python, Android, Flutter/Dart, Node.js, HarmonyOS, and Maven artifacts. - Update release automation/config files (e.g.,
new-release.sh,jitpack.yml) to point at the new release assets/version codes. - Add
1.12.32section toCHANGELOG.mdand update embedded archive URLs/examples.
Reviewed changes
Copilot reviewed 64 out of 64 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sherpa-onnx/rust/sherpa-onnx/src/lib.rs | Updates Rust crate docs to reference v1.12.32 and corresponding release archives. |
| sherpa-onnx/rust/sherpa-onnx/README.md | Updates README dependency snippets to v1.12.32. |
| sherpa-onnx/rust/sherpa-onnx/Cargo.toml | Bumps sherpa-onnx crate version and sherpa-onnx-sys dependency version. |
| sherpa-onnx/rust/sherpa-onnx-sys/Cargo.toml | Bumps sherpa-onnx-sys crate version. |
| sherpa-onnx/csrc/version.cc | Updates embedded git date/sha and version string to 1.12.32. |
| setup.py | Updates split-package dependency pin to sherpa-onnx-core==1.12.32. |
| scripts/wheel/sherpa-onnx-core/setup.py | Bumps Python wheel package version to 1.12.32. |
| scripts/wheel/sherpa-onnx-bin/setup.py | Bumps Python bin wheel version and core dependency pin to 1.12.32. |
| rust-api-examples/for-advanced-users.md | Updates example archive names and dependency snippets to v1.12.32. |
| rust-api-examples/Cargo.toml | Bumps examples crate and sherpa-onnx dependency version to 1.12.32. |
| pom.xml | Bumps Maven POM version to 1.12.32. |
| nodejs-examples/package.json | Bumps Node dependency sherpa-onnx to ^1.12.32. |
| nodejs-addon-examples/package.json | Bumps Node dependency sherpa-onnx-node to ^1.12.32. |
| new-release.sh | Updates release automation variables for version/code progression to 1.12.32. |
| mfc-examples/README.md | Updates Windows prebuilt exe download links to v1.12.32. |
| jitpack.yml | Updates JitPack install script to download/install sherpa-onnx-1.12.32.aar. |
| harmony-os/SherpaOnnxVadAsr/entry/oh-package.json5 | Bumps HarmonyOS dependency sherpa_onnx to 1.12.32. |
| harmony-os/SherpaOnnxVadAsr/entry/README.md | Updates referenced HAR filename to v1.12.32. |
| harmony-os/SherpaOnnxTts/entry/oh-package.json5 | Bumps HarmonyOS dependency sherpa_onnx to 1.12.32. |
| harmony-os/SherpaOnnxStreamingAsr/entry/oh-package.json5 | Bumps HarmonyOS dependency sherpa_onnx to 1.12.32. |
| harmony-os/SherpaOnnxSpeakerIdentification/entry/oh-package.json5 | Bumps HarmonyOS dependency sherpa_onnx to 1.12.32. |
| harmony-os/SherpaOnnxSpeakerDiarization/entry/oh-package.json5 | Bumps HarmonyOS dependency sherpa_onnx to 1.12.32. |
| harmony-os/SherpaOnnxHar/sherpa_onnx/oh-package.json5 | Bumps HarmonyOS package version to 1.12.32. |
| harmony-os/SherpaOnnxHar/sherpa_onnx/README.md | Updates dependency snippet to sherpa_onnx: 1.12.32. |
| harmony-os/SherpaOnnxHar/sherpa_onnx/BuildProfile.ets | Updates HAR version constant to 1.12.32. |
| flutter/sherpa_onnx_macos/macos/sherpa_onnx_macos.podspec | Bumps CocoaPods spec version to 1.12.32. |
| flutter/sherpa_onnx_ios/ios/sherpa_onnx_ios.podspec | Bumps CocoaPods spec version to 1.12.32. |
| flutter/sherpa_onnx/pubspec.yaml | Bumps Flutter package version and platform package constraints to 1.12.32. |
| flutter-examples/tts/pubspec.yaml | Bumps example app version and dependency to ^1.12.32. |
| flutter-examples/streaming_asr/pubspec.yaml | Bumps example app version and dependency to ^1.12.32. |
| flutter-examples/non_streaming_vad_asr/pubspec.yaml | Bumps example app version and dependency to ^1.12.32. |
| dart-api-examples/vad/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/vad-with-non-streaming-asr/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/tts/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/streaming-asr/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/spoken-language-identification/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/speech-enhancement-gtcrn/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/speech-enhancement-dpdfnet/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/speaker-identification/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/speaker-diarization/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/non-streaming-asr/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/keyword-spotter/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/audio-tagging/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| dart-api-examples/add-punctuations/pubspec.yaml | Bumps Dart example dependency to ^1.12.32. |
| build-ios-shared.sh | Bumps iOS framework CFBundleShortVersionString to 1.12.32. |
| android/SherpaOnnxWebSocket/app/build.gradle | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxVadAsr/app/build.gradle | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxVad/app/build.gradle | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxTtsEngine/app/build.gradle.kts | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxTts/app/build.gradle | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxSpokenLanguageIdentification/app/build.gradle.kts | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxSpeakerIdentification/app/build.gradle.kts | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxSpeakerDiarization/app/build.gradle.kts | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxSimulateStreamingAsrWearOs/app/build.gradle.kts | Bumps app version and updates dependency to com.github.k2-fsa:sherpa-onnx:v1.12.32. |
| android/SherpaOnnxSimulateStreamingAsr/app/build.gradle.kts | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxKws/app/build.gradle | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxJavaDemo/app/build.gradle | Bumps app version and updates dependency to com.github.k2-fsa:sherpa-onnx:v1.12.32. |
| android/SherpaOnnxAudioTaggingWearOs/app/build.gradle.kts | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxAudioTagging/app/build.gradle.kts | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnxAar/README.md | Updates Android AAR build instructions and filenames to 1.12.32. |
| android/SherpaOnnx2Pass/app/build.gradle | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| android/SherpaOnnx/app/build.gradle | Bumps Android app versionCode/versionName to 20260322 / 1.12.32. |
| CMakeLists.txt | Bumps CMake project version variable to 1.12.32. |
| CHANGELOG.md | Adds 1.12.32 release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,3 +1,9 @@ | |||
| ## 1.12.32 | |||
|
|
|||
| * Support static link for Rust package. (#3386) | |||
There was a problem hiding this comment.
The new changelog entry uses slightly inconsistent wording/punctuation compared to adjacent entries (e.g., 'static link' vs 'static linking', and this bullet is the only one ending with a period before the PR reference). Consider updating it to match the surrounding changelog style for consistency.
Suggested change
| * Support static link for Rust package. (#3386) | |
| * Support static linking for Rust package (#3386) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request updates the sherpa-onnx version to 1.12.32 across various files, including build configurations, documentation, and dependency specifications for Android, iOS, HarmonyOS, Flutter, Rust, Python, MFC examples, and Node.js examples. The review comment suggests improving the jitpack.yml file by defining the version and artifact filename as variables to enhance maintainability and reduce redundancy.
Comment on lines
4
to
+9
| before_install: | ||
| - wget https://github.com/k2-fsa/sherpa-onnx/releases/download/v1.12.31/sherpa-onnx-1.12.31.aar | ||
| - wget https://github.com/k2-fsa/sherpa-onnx/releases/download/v1.12.32/sherpa-onnx-1.12.32.aar | ||
|
|
||
| install: | ||
| - FILE="-Dfile=sherpa-onnx-1.12.31.aar" | ||
| - mvn install:install-file $FILE -DgroupId=com.k2fsa.sherpa.onnx -DartifactId=sherpa-onnx -Dversion=1.12.31 -Dpackaging=aar -DgeneratePom=true | ||
| - FILE="-Dfile=sherpa-onnx-1.12.32.aar" | ||
| - mvn install:install-file $FILE -DgroupId=com.k2fsa.sherpa.onnx -DartifactId=sherpa-onnx -Dversion=1.12.32 -Dpackaging=aar -DgeneratePom=true |
There was a problem hiding this comment.
To improve maintainability and reduce redundancy, you could define the version and artifact filename as variables. This makes it easier to update the version in a single place and reduces the risk of inconsistencies during releases.
before_install:
- export SHERPA_ONNX_VERSION="1.12.32"
- export AAR_FILE="sherpa-onnx-${SHERPA_ONNX_VERSION}.aar"
- wget "https://github.com/k2-fsa/sherpa-onnx/releases/download/v${SHERPA_ONNX_VERSION}/${AAR_FILE}"
install:
- FILE="-Dfile=${AAR_FILE}"
- mvn install:install-file $FILE -DgroupId=com.k2fsa.sherpa.onnx -DartifactId=sherpa-onnx -Dversion=${SHERPA_ONNX_VERSION} -Dpackaging=aar -DgeneratePom=true
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores