Skip to content

Update Qwen3 ASR models - #3476

Merged
csukuangfj merged 1 commit into
k2-fsa:masterfrom
csukuangfj:upload-models
Apr 7, 2026
Merged

csukuangfj merged 1 commit into
k2-fsa:masterfrom
csukuangfj:upload-models

Conversation

@csukuangfj

@csukuangfj csukuangfj commented Apr 7, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #3473

Summary by CodeRabbit

  • Chores
    • Qwen3 ASR tests now execute unconditionally in CI/CD pipelines across all platforms instead of being conditionally skipped based on system configuration.
    • Updated workflow trigger branch and modified step conditions in model upload pipeline.

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 7, 2026
@coderabbitai

coderabbitai Bot commented Apr 7, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 23044606-5739-44f7-8a7e-1e4b0c19f254

📥 Commits

Reviewing files that changed from the base of the PR and between b86cc45 and 4b48d18.

📒 Files selected for processing (16)
  • .github/scripts/test-dart.sh
  • .github/scripts/test-dot-net.sh
  • .github/scripts/test-nodejs-addon-npm.sh
  • .github/scripts/test-python.sh
  • .github/scripts/test-rust.sh
  • .github/workflows/run-python-test.yaml
  • .github/workflows/test-dart-package.yaml
  • .github/workflows/test-dart.yaml
  • .github/workflows/test-dot-net-nuget.yaml
  • .github/workflows/test-dot-net.yaml
  • .github/workflows/test-nodejs-addon-api.yaml
  • .github/workflows/test-nodejs-addon-npm.yaml
  • .github/workflows/test-rust-package-static.yaml
  • .github/workflows/test-rust-package.yaml
  • .github/workflows/test-rust.yaml
  • .github/workflows/upload-models.yaml

📝 Walkthrough

Walkthrough

This pull request removes conditional guards that previously skipped Qwen3 ASR testing in CI pipelines. Test scripts now unconditionally execute Qwen3 ASR model downloads, extractions, tests, and cleanups regardless of platform. Correspondingly, workflow YAML files no longer export SKIP_QWEN3=true on ubuntu-latest. The upload-models workflow also updates its trigger branch and modifies step conditions.

Changes

Cohort / File(s) Summary
Test Scripts
.github/scripts/test-dart.sh, .github/scripts/test-dot-net.sh, .github/scripts/test-nodejs-addon-npm.sh, .github/scripts/test-python.sh, .github/scripts/test-rust.sh
Removed SKIP_QWEN3 conditional guards, making Qwen3 ASR test execution (model download, extraction, test runs, cleanup) unconditional across all platforms.
Workflow Files
.github/workflows/run-python-test.yaml, .github/workflows/test-dart-package.yaml, .github/workflows/test-dart.yaml, .github/workflows/test-dot-net-nuget.yaml, .github/workflows/test-dot-net.yaml, .github/workflows/test-nodejs-addon-api.yaml, .github/workflows/test-nodejs-addon-npm.yaml, .github/workflows/test-rust-package-static.yaml, .github/workflows/test-rust-package.yaml, .github/workflows/test-rust.yaml
Removed OS-specific conditional exports of SKIP_QWEN3=true for ubuntu-latest, allowing Qwen3 ASR tests to run on all platforms without environment-based skipping.
Upload Models Workflow
.github/workflows/upload-models.yaml
Changed push trigger branch from upload-models to upload-models-2, disabled cohere-transcribe download step with if: false, and renamed "Collect funasr-nano with LLM int8" to "Collect Qwen3-ASR with LLM int8".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

size:M

Poem

🐰 No more skipping for the Qwen, tests now run with zen,
Ubuntu-latest hops along, with Qwen3's song,
Models download, extract, and test complete,
CI pipelines now skip no beat—success so sweet!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@csukuangfj
csukuangfj merged commit 178cee0 into k2-fsa:master Apr 7, 2026
0 of 7 checks passed
@csukuangfj
csukuangfj deleted the upload-models branch April 7, 2026 10:04

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the conditional logic that previously allowed skipping Qwen3 ASR tests via the SKIP_QWEN3 environment variable across various CI scripts, including Dart, .NET, Node.js, Python, and Rust. As a result, these tests will now execute unconditionally in the affected workflows. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Qwen3-asr Windows版本返回结果异常

1 participant