Upload models for https://huggingface.co/CohereLabs/cohere-transcribe-03-2026 - #3453
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/upload-models.yaml:
- Around line 27-52: Remove the redundant "if: true" from the "Download
cohere-transcribe" GitHub Actions step and verify/add download of tokens.txt:
locate the step titled "Download cohere-transcribe" in the workflow, delete the
if: true line, then check the model repo for a tokens.txt file and if present
add a curl -SL -O call to fetch tokens.txt alongside README.md,
decoder.int8.onnx, encoder.int8.onnx.data and encoder.int8.onnx so the step
mirrors other ASR model downloads.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 30ee06be-eee5-4e6f-96f3-54d475b5754a
📒 Files selected for processing (1)
.github/workflows/upload-models.yaml
| - name: Download cohere-transcribe | ||
| if: true | ||
| shell: bash | ||
| run: | | ||
| d=sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01 | ||
| mkdir -p $d | ||
| pushd $d | ||
|
|
||
| mkdir ./test_wavs | ||
| cd ./test_wavs | ||
| for w in ar de en es fr ja ko vi zh; do | ||
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/test_wavs/$w.wav | ||
| done | ||
| ls -lh | ||
| cd .. | ||
|
|
||
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/README.md | ||
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/decoder.int8.onnx | ||
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/encoder.int8.onnx.data | ||
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/encoder.int8.onnx | ||
|
|
||
| ls -lh | ||
| popd | ||
|
|
||
| tar cjvf $d.tar.bz2 $d | ||
| ls -lh $d $d.tar.bz2 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if tokens.txt exists in the ModelScope repository
curl -sI "https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/tokens.txt" | head -20Repository: k2-fsa/sherpa-onnx
Length of output: 954
🏁 Script executed:
#!/bin/bash
# Search for cohere-transcribe references in the repository
rg "cohere-transcribe" -i --max-count=20Repository: k2-fsa/sherpa-onnx
Length of output: 44
🏁 Script executed:
#!/bin/bash
# Look for tokens.txt references in the workflow and tests
rg "tokens\.txt" --max-count=20 -A 2 -B 2Repository: k2-fsa/sherpa-onnx
Length of output: 50375
🏁 Script executed:
#!/bin/bash
# Check the upload-models workflow file structure around this section
head -60 .github/workflows/upload-models.yaml | tail -35Repository: k2-fsa/sherpa-onnx
Length of output: 1515
Remove redundant if: true condition.
Line 28 has if: true which is redundant—the step runs unconditionally by default and will be flagged by actionlint.
Additionally, this step downloads only README.md, decoder.int8.onnx, encoder.int8.onnx.data, and encoder.int8.onnx, but does not download a tokens.txt file. All other ASR models in this workflow (FireRedASR2, Whisper, SenseVoice, Moonshine, Paraformer, etc.) include tokens.txt in their downloads. Please verify whether tokens.txt is available and required for the cohere-transcribe model.
Suggested fix for redundant condition
- name: Download cohere-transcribe
- if: true
shell: bash
run: |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Download cohere-transcribe | |
| if: true | |
| shell: bash | |
| run: | | |
| d=sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01 | |
| mkdir -p $d | |
| pushd $d | |
| mkdir ./test_wavs | |
| cd ./test_wavs | |
| for w in ar de en es fr ja ko vi zh; do | |
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/test_wavs/$w.wav | |
| done | |
| ls -lh | |
| cd .. | |
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/README.md | |
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/decoder.int8.onnx | |
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/encoder.int8.onnx.data | |
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/encoder.int8.onnx | |
| ls -lh | |
| popd | |
| tar cjvf $d.tar.bz2 $d | |
| ls -lh $d $d.tar.bz2 | |
| - name: Download cohere-transcribe | |
| shell: bash | |
| run: | | |
| d=sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01 | |
| mkdir -p $d | |
| pushd $d | |
| mkdir ./test_wavs | |
| cd ./test_wavs | |
| for w in ar de en es fr ja ko vi zh; do | |
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/test_wavs/$w.wav | |
| done | |
| ls -lh | |
| cd .. | |
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/README.md | |
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/decoder.int8.onnx | |
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/encoder.int8.onnx.data | |
| curl -SL -O https://modelscope.cn/models/csukuangfj/sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01/resolve/master/encoder.int8.onnx | |
| ls -lh | |
| popd | |
| tar cjvf $d.tar.bz2 $d | |
| ls -lh $d $d.tar.bz2 |
🧰 Tools
🪛 actionlint (1.7.11)
[error] 28-28: constant expression "true" in condition. remove the if: section
(if-cond)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/upload-models.yaml around lines 27 - 52, Remove the
redundant "if: true" from the "Download cohere-transcribe" GitHub Actions step
and verify/add download of tokens.txt: locate the step titled "Download
cohere-transcribe" in the workflow, delete the if: true line, then check the
model repo for a tokens.txt file and if present add a curl -SL -O call to fetch
tokens.txt alongside README.md, decoder.int8.onnx, encoder.int8.onnx.data and
encoder.int8.onnx so the step mirrors other ASR model downloads.
See also #3442
Download it from
sherpa-onnx-cohere-transcribe-14-lang-int8-2026-04-01.tar.bz2
Summary by CodeRabbit
New Features
Chores