Skip to content

tests: remove jira-wrapper artifact-location fallback (#2136) #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwbron merged 1 commit into from
Apr 27, 2026
Merged

tests: remove jira-wrapper artifact-location fallback (#2136) #2138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions tests/sandbox/test_jira_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@
- Missing ``EGG_SESSION_TOKEN`` fails closed.
- Missing gateway fails closed with the standard error banner.

The wrapper lives at ``sandbox/scripts/jira`` (canonical) or the artifact
location ``.egg-state/agent-outputs/1556-sandbox-scripts-jira`` (until a
role with push rights for ``sandbox/scripts/`` lands it at the canonical
path). Either is acceptable for verification; the test prefers the
canonical location when present.

Note: this file exercises the wrapper directly; the actual route
enforcement (private-mode gate, project allowlist, etc.) is covered in
``gateway/tests/test_jira_routes.py``. The wrapper's only job is to
Expand All @@ -43,18 +37,14 @@

_REPO_ROOT = Path(__file__).resolve().parents[2]
_CANONICAL = _REPO_ROOT / "sandbox" / "scripts" / "jira"
_ARTIFACT = _REPO_ROOT / ".egg-state" / "agent-outputs" / "1556-sandbox-scripts-jira"


def _locate_wrapper() -> Path:
"""Return the wrapper path; skip the test if neither is present."""
"""Return the wrapper path; skip the test if it is not present."""
if _CANONICAL.exists():
return _CANONICAL
if _ARTIFACT.exists():
return _ARTIFACT
pytest.skip(
"sandbox jira wrapper not found at "
f"{_CANONICAL} or {_ARTIFACT} — coder proposal #1556 may be incomplete.",
f"sandbox jira wrapper not found at {_CANONICAL}.",
allow_module_level=True,
)

Expand Down
Loading