tests: remove jira-wrapper artifact-location fallback (#2136) - #2138
Merged
Conversation
The fallback in `tests/sandbox/test_jira_wrapper.py` was scaffolding for the pre-#2135 workaround when `sandbox/scripts/` was blocked from agent writes. With #2135 merged, new wrappers land at the canonical path directly and the artifact location is permanently dead code. Drops the docstring paragraph, the `_ARTIFACT` constant, and the fallback branch in `_locate_wrapper()`; simplifies the skip message.
![egg-reviewer[bot]](https://avatars.githubusercontent.com/u/8340608?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Approve. Clean dead-code removal.
Verified:
sandbox/scripts/jiraexists at the canonical path (executable, current)..egg-state/agent-outputs/1556-sandbox-scripts-jiradoes not exist; the fallback path is unreachable.- #2135 merged 2026-04-27, so the rationale for the artifact-fallback dance ("until a role with push rights for
sandbox/scripts/lands it at the canonical path") no longer holds. - No other references to
1556-sandbox-scripts-jiraor_ARTIFACTremain anywhere intests/,sandbox/,docs/,shared/,orchestrator/, orgateway/(the two_READ_PEER_ARTIFACT_SCHEMAhits insandbox/egg_agent_tools/tools/brc.pyare unrelated BRC schema names). pytest tests/sandbox/test_jira_wrapper.py→ 19/19 passed locally.
The diff is exactly what the description claims: docstring paragraph, _ARTIFACT constant, fallback if branch, and the dual-path skip message all gone; skip message simplified to reference _CANONICAL only. Nothing else touched.
— Authored by egg
Contributor
|
egg review completed. View run logs |
james-in-a-box Bot
pushed a commit
that referenced
this pull request
Apr 28, 2026
The fallback in `tests/sandbox/test_jira_wrapper.py` was scaffolding for the pre-#2135 workaround when `sandbox/scripts/` was blocked from agent writes. With #2135 merged, new wrappers land at the canonical path directly and the artifact location is permanently dead code. Drops the docstring paragraph, the `_ARTIFACT` constant, and the fallback branch in `_locate_wrapper()`; simplifies the skip message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.egg-state/agent-outputs/1556-sandbox-scripts-jirafallback intests/sandbox/test_jira_wrapper.py. With patterns: drop sandbox/scripts wholesale block, enforce via reviewer_security (#2133) #2135 merged, new wrappers land atsandbox/scripts/jiradirectly and the artifact location can never appear._ARTIFACTconstant, and the fallback branch in_locate_wrapper(); simplifies the skip message accordingly.Closes #2136.
Test plan
pytest tests/sandbox/test_jira_wrapper.py— 19/19 passed locally_ARTIFACTor1556-sandbox-scripts-jirain the file