Repository navigation
ci: unbreak the Rust quality lane on main, a fifth time - #1492
Merged
Merged
Conversation
`cargo fmt --all -- --check` is a hard gate in both the Fast (Linux x86_64) and Rust quality lanes, and it is failing on `main` at ba52d17 with four diffs, all in `crates/onnx-runtime-ep-cuda/src/optimizer.rs`: one method chain at line 308 and three in the `CudaRsqrtFusion` tests. Every PR that merges main inherits the failure, so the queue cannot go green until it is repaired. This is the same lane #1393 unbroke, breaking again. Pure `cargo fmt --all` output -- no semantic change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
==========================================
+ Coverage 82.10% 82.64% +0.54%
==========================================
Files 12 12
Lines 5471 5475 +4
Branches 5471 5475 +4
==========================================
+ Hits 4492 4525 +33
+ Misses 780 757 -23
+ Partials 199 193 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmt --all -- --checkis a hard gate in bothFast (Linux x86_64)andRust quality, and it fails onmain@ba52d1702with four diffs, all incrates/onnx-runtime-ep-cuda/src/optimizer.rs— one method chain at line 308, three in theCudaRsqrtFusiontests.Every PR that merges main inherits it, so nothing in the queue can go green until it is repaired. Same lane #1393 unbroke four days of breakages ago.
Pure
cargo fmt --alloutput. No semantic change.Local validation
cargo fmt --all -- --checkcargo test --locked $(… offline-linux)cargo clippy --locked --all-targets $(… offline-linux) -- -D warningscargo check -p onnx-runtime-ep-cudascripts/check_cross_compile.sh