Repository navigation
style: rustfmt repair after #1100 - #1102
Merged
Merged
Conversation
`main` fails `cargo fmt --all -- --check` at a0ed99a, which fails every branch cut from it. Pure rustfmt output, no logic change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
+ Coverage 79.76% 80.40% +0.64%
==========================================
Files 367 367
Lines 156416 156410 -6
Branches 156416 156410 -6
==========================================
+ Hits 124765 125764 +999
+ Misses 26947 25940 -1007
- Partials 4704 4706 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
🔴 Benchmark Regression DetectedComparison of criterion micro-benchmarks: PR head vs merge-base, measured on the same runner in the same job (base first → PR second).
Visual flags: Host infoWhat this cannot catch
|
justinchuby
added a commit
that referenced
this pull request
Aug 17, 2026
`cargo fmt --all -- --check` fails on `main` at 9b7a458 (#1104), in `crates/onnx-runtime-ep-cpu/src/kernels/matmul_nbits.rs:6239`. Every open PR's `Rust quality` job therefore fails for a reason unrelated to the PR. This is the third time (see #1089, #1102): the merge queue does not re-run formatting against the merge result, so an individually-green PR can still land unformatted `main`. Pure `cargo fmt -p onnx-runtime-ep-cpu` output, two lines, no behaviour change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mainis fmt-broken at a0ed99a (#1100).mainis unprotected and the merge queue does not re-run CI on the merge result, so this fails the Check formatting step of both Fast (Linux x86_64) and Rust quality on every branch cut from it — including #1101, which is how I found it.What this is
The literal output of
cargo fmt --all, nothing else. No logic change, no test change. 17 insertions, 20 deletions, all whitespace and line-wrapping.Verification
cargo fmt --all -- --check— cleancargo test -p onnx-runtime-ep-cpu --lib— unchanged