Repository navigation
style: restore rustfmt cleanliness on main - #1089
Merged
Merged
Conversation
`cargo fmt --all -- --check` currently fails on `origin/main` in five places across `kernels/gemm.rs` and `kernels/matmul.rs`. Nobody wrote badly-formatted code. #1073, #1079 and #1080 each touched these two files, and each was fmt-clean against its own base. Squash-merging them produced a combined text that rustfmt formats differently: `TRANSPOSE_TEST_LOCK.lock() .unwrap_or_else(...)` is 61 characters and so exceeds the default `chain_width` of 60 once it sits at test-body indentation, the `onnx_runtime_ir` import list grew past `max_width`, and one `Gemm`/`transB` chain became short enough to fit on a single line after a neighbouring edit. `main` is unprotected, so no required check re-ran fmt on the merge result. This is `cargo fmt --all` output and nothing else -- no logic changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1089 +/- ##
========================================
Coverage 79.79% 79.80%
========================================
Files 369 369
Lines 161558 161732 +174
Branches 161558 161732 +174
========================================
+ Hits 128915 129068 +153
- Misses 27898 27916 +18
- Partials 4745 4748 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
🔴 Benchmark Regression DetectedComparison of criterion micro-benchmarks: PR head vs merge-base, measured on the same runner in the same job (base first → PR second).
Visual flags: Host infoWhat this cannot catch
|
justinchuby
marked this pull request as ready for review
August 16, 2026 21:16
justinchuby
added a commit
that referenced
this pull request
Aug 17, 2026
`cargo fmt --all -- --check` fails on `main` at 9b7a458 (#1104), in `crates/onnx-runtime-ep-cpu/src/kernels/matmul_nbits.rs:6239`. Every open PR's `Rust quality` job therefore fails for a reason unrelated to the PR. This is the third time (see #1089, #1102): the merge queue does not re-run formatting against the merge result, so an individually-green PR can still land unformatted `main`. Pure `cargo fmt -p onnx-runtime-ep-cpu` output, two lines, no behaviour change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
cargo fmt --all -- --checkcurrently fails onorigin/main(bce03cabb) in fiveplaces across
crates/onnx-runtime-ep-cpu/src/kernels/gemm.rsandcrates/onnx-runtime-ep-cpu/src/kernels/matmul.rs. This is thecargo fmt --alloutputand nothing else.
Why it happened
Nobody wrote badly-formatted code. #1073, #1079 and #1080 each touched these two files and
each was fmt-clean against its own base. Squash-merging them produced a combined text that
rustfmt formats differently:
TRANSPOSE_TEST_LOCK.lock().unwrap_or_else(|e| e.into_inner())is 61 characters, whichexceeds rustfmt's default
chain_widthof 60 once it sits at test-body indentation (twosites).
onnx_runtime_irimport list grew pastmax_widthand now wants braces on their ownlines.
Gemm/transBattribute chain became short enough to fit on a single line after aneighbouring edit.
mod tests.mainis unprotected, so no required check re-ran fmt on the merge result and the breakagelanded silently.
How it was found
It blocked #1086: that PR's
Fast (Linux x86_64)andRust qualityjobs failed on thePR merge ref with diffs in files #1086 does not touch. Reproduced independently by
checking out
origin/maininto a clean worktree and runningcargo fmt --all -- --check.Verification
cargo fmt --all -- --check-> clean (was: 5 diffs).git diff -won the two files is empty apart fromthe import-brace move. No logic, no behaviour, no test changes.
Risk
None. Mechanical formatter output.