Repository navigation
docs(decide): name Laya as the second decide provider #1807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MINOR — intended as a non-blocking note; the author's rationale is accepted.
Adding the
Layachip here makes the inconsistency on this same rendered page one click easier to hit: the provider grid now enumerates 23 names, while the byte-identical (unmodified) copy elsewhere in this file still says 40:QUICK_LINKSSDK Guide description —"Unified API for 40 providers""Unified API for 40 AI providers"<Layout description="...from 40 providers...">The commit message transparently documents that only sentences the diff touches must drop their counts, and sentences it does not touch are deferred — I accept that scoping. But
docs/features/index.md's "Platform Capabilities" / "AI Provider Integration" tables (both un-touched) also still assert 40.No code change required; if you want to fold the remaining count out before merge, the three
index.tsxstrings and the twofeatures/index.mdtable rows above are the complete set (verified against base8fc9088→ headf2387f4). Leaving them for the stated follow-up pass is fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in bae3755: the hardcoded provider counts are gone. index.tsx (SDK Guide card, routing card, Layout description) and docs/features/index.md now say supported providers or many AI providers instead of 40.