Repository navigation
docs(decide): name Laya as the second decide provider - #1807
Conversation
The README and docs still described TypeSafe Jev as the only decide provider. Laya merged as the second one in #1789 (9ded25d, v12.26.0), but nothing outside docs/getting-started/providers/laya.md said so. Updates every "only"/"first"/"sole" decide-provider claim across README.md, docs/index.md, docs/features/index.md, docs/getting-started/provider-setup.md, docs/getting-started/providers/index.md, docs/getting-started/providers/typesafe.md, docs/reference/faq.md, docs/skills/neurolink-guide/providers.md, docs/about/nervous-system-model.md and the docs-site FAQ and provider list in docs-site/src/pages/index.tsx, and adds a README highlight for Laya (Apache-2.0, open-weights, self-hosted via LAYA_API_KEY/LAYA_BASE_URL, TypeSafe first when both are configured) alongside the existing TypeSafe one. The README's latency and cost figures are now attributed to Jev. Sentences this diff touches no longer carry a total provider count: with Laya added, their "40" no longer matched their own enumeration. Totals in sentences it does not touch are left for a separate pass. docs-site/static/search-index.json is regenerated from the changes above and was byte-identical across two docs-site builds.
|
Warning Review limit reachedNext included review available in 44 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: juspay/neurolink/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Single Commit Policy - COMPLIANTStatus: Policy requirements met • 1 commit • Valid format • Ready for merge 📊 View validation details📝 Commit Details
✅ Validation Results
🤖 Automated validation by NeuroLink Single Commit Enforcement |
Documentation Validation Results🚀 Documentation validation passed!
📦 Build artifact uploaded successfully. Ready for deployment preview. Commit: |
Tara-ag
left a comment
Tara-ag
left a comment
There was a problem hiding this comment.
Approving this docs pass: Laya provider messaging is consistent across the sections this diff touches, and the author transparently documented the deferred count updates. Non-blocking note on remaining "40 providers" strings on lines outside the diff (see inline).
| "Azure Speech", | ||
| "OpenAI TTS", | ||
| "TypeSafe", | ||
| "Laya", |
There was a problem hiding this comment.
MINOR — intended as a non-blocking note; the author's rationale is accepted.
Adding the Laya chip here makes the inconsistency on this same rendered page one click easier to hit: the provider grid now enumerates 23 names, while the byte-identical (unmodified) copy elsewhere in this file still says 40:
QUICK_LINKSSDK Guide description —"Unified API for 40 providers"- routing card —
"Unified API for 40 AI providers" <Layout description="...from 40 providers...">
The commit message transparently documents that only sentences the diff touches must drop their counts, and sentences it does not touch are deferred — I accept that scoping. But docs/features/index.md's "Platform Capabilities" / "AI Provider Integration" tables (both un-touched) also still assert 40.
| "Laya", | |
| "Laya", |
No code change required; if you want to fold the remaining count out before merge, the three index.tsx strings and the two features/index.md table rows above are the complete set (verified against base 8fc9088 → head f2387f4). Leaving them for the stated follow-up pass is fine.
There was a problem hiding this comment.
Fixed in bae3755: the hardcoded provider counts are gone. index.tsx (SDK Guide card, routing card, Layout description) and docs/features/index.md now say supported providers or many AI providers instead of 40.
|
APPROVE — A disciplined, well-scoped docs pass: the commit message transparently scopes count updates to only the sentences the diff touches and defers the rest, and Laya messaging is consistent across every section that this diff actually edits. Findings
What was checked and found clean
No CRITICAL or MAJOR findings. No secrets, no provider code, no runtime impact. |
|
🎉 This PR is included in version 12.28.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Pull Request
Description
What does this PR do?
Names Laya as the second
decideprovider everywhere the README and docs describedecide, and adds a README highlight for it next to the TypeSafe one: what it is (Convai Innovations' Apache-2.0 open-weights model), how to use it (LAYA_API_KEY+LAYA_BASE_URL, orcredentials.layain the SDK config or per call; no built-in endpoint), when it fits (short states — about 768 tokens on the default checkpoint), and where NeuroLink uses it (the same built-in decide consumers, TypeSafe first when both are configured).Related Issues
Relates to #1789 (Laya merged as the second decision provider, shipped in 12.26.0).
Type of Change
Motivation and Context
Since 12.26.0 the README and several docs pages were wrong: they said TypeSafe Jev is the only (or sole, or first-and-only)
decideprovider — "TypeSafe Jev alone servesdecide", "the only provider servingdecide", "the single provider of the 40 that does". Nothing outsidedocs/getting-started/providers/laya.mdmentioned Laya.README.md,docs/index.md,docs/features/index.md,docs/getting-started/provider-setup.md,docs/getting-started/providers/index.md,docs/getting-started/providers/typesafe.md,docs/reference/faq.md,docs/skills/neurolink-guide/providers.md,docs/about/nervous-system-model.md, and the docs-site FAQ indocs-site/src/pages/index.tsx.PROVIDER_DESCRIPTORS(30 native, 3 model-dependent, 9 none).How Has This Been Tested?
pnpm run format:check— clean.pnpm --dir docs-site run buildtwice on the rebased tree —docs-site/static/search-index.jsonbyte-identical across both runs and equal to the committed file.pnpm --dir docs-site run test:search-index-reproducibility— PASS.check,validate:all,lint, commit-message validation) and pre-push hook — pass.src/lib/providers/laya.ts,systemOneDecision.tsandproviderDescriptors.ts, recounted the tally, and grepped for remaining "only decide provider" claims.No code changes.