Repository navigation
ci(release): install ffmpeg from apt so publishes stop failing - #1348
Conversation
The publish workflow still used the third-party setup-ffmpeg action that ci.yml was just moved off. It is failing the same way — "xz: (stdin): File format not recognized" — which fails the release job before semantic-release runs. The effect is worse here than in CI, because it is silent: pull requests merge, CI on release goes green, and nothing publishes. Two merges have landed on release since the last successful publish and neither produced a version. Same replacement as ci.yml: install from the runner's package index, which cannot be invalidated by an upstream release being moved or rebuilt.
✅ Single Commit Policy - COMPLIANTStatus: Policy requirements met • 1 commit • Valid format • Ready for merge 📊 View validation details📝 Commit Details
✅ Validation Results
🤖 Automated validation by NeuroLink Single Commit Enforcement |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 2 reviews per rolling hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe test and release jobs in the release workflow now install FFmpeg with ChangesFFmpeg CI installation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This is a localized release-workflow change to install ffmpeg from the runner package index; no actionable merge-blocking risk remains after normal checks. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the release/publish GitHub Actions workflow to install ffmpeg via the Ubuntu runner’s APT package index instead of relying on the third-party AnimMouse/setup-ffmpeg action, preventing upstream asset/download failures from silently blocking releases on the release branch.
Changes:
- Replaced
AnimMouse/setup-ffmpeg@v1withapt-get install ffmpegin thetestjob. - Replaced
AnimMouse/setup-ffmpeg@v1withapt-get install ffmpegin thereleasejob. - Updated the verification failure message to reference the new installation method.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
🤖 AI Review & Build Compliance ✅Status: AI analysis complete • Build rules validated • Ready for review 📊 View detailed analysis results🛡️ Analysis Complete
📋 Ready for Merge When
🤖 AI analysis complete - check individual code comments for specific feedback |
|
@juspay/neurolink-bot This is a Yama automated code review for PR #1348. Review SummaryDecision: APPROVED This is a CI/CD workflow change that addresses a critical release-blocking issue. The Changes Made:
Verification:✅ No source code files affected Why This Change is Necessary:The upstream
This is significantly worse than the CI pipeline issue because it affects production releases while appearing healthy. Conclusion:This change restores reliable release publishing by using the runner's system package manager instead of relying on potentially broken third-party assets. The change is minimal, well-documented, and follows the same pattern already applied to No inline comments required - this is a CI workflow improvement with no code quality concerns. |
✅ Yama Review SummaryDecision: APPROVED This is a CI/CD workflow change that addresses a critical release-blocking issue. The Changes Made:
Verification:✅ No source code files affected Why This Change is Necessary:The upstream
This is significantly worse than the CI pipeline issue because it affects production releases while appearing healthy. Consistency Check:This change mirrors the same fix already applied to Impact Analysis:
Conclusion:This change restores reliable release publishing by using the runner's system package manager instead of relying on potentially broken third-party assets. The change is minimal, well-documented, follows the same pattern already applied to No inline comments required - this is a CI workflow improvement with no code quality concerns. |
|
🎉 This PR is included in version 11.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Nothing has published since 11.1.0. Two PRs have merged to
releasesince then and neither produced a version.release.ymlstill uses the third-partyAnimMouse/setup-ffmpegaction that #1342 movedci.ymloff. It is failing identically —xz: (stdin): File format not recognized— which fails thereleasejob before semantic-release ever runs.This failure mode is worse than the CI one because it is silent. Pull requests merge, CI on
releasereports green, and no release goes out; you only notice by checking npm. Runs 32114361501 and 32117776035 both failed this way.Same replacement as #1342: install from the runner's package index, in both jobs that need it, so an upstream release being moved, rebuilt or rate-limited can no longer stop a publish. Also updates the failure message, which still pointed at the removed action.
Once this lands, the two already-merged changes (
fix(cli)setup flag forwarding,fix(providers)transport-error classification) should publish on the next release run.Summary by CodeRabbit