Repository navigation
ci(workflows): install ffmpeg from apt instead of a third-party downloader - #1342
Conversation
✅ Single Commit Policy - COMPLIANTStatus: Policy requirements met • 1 commit • Valid format • Ready for merge 📊 View validation details📝 Commit Details
✅ Validation Results
🤖 Automated validation by NeuroLink Single Commit Enforcement |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 2 reviews per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CI workflow replaces the pinned FFmpeg setup action with noninteractive APT installation in the ChangesCI FFmpeg installation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized CI workflow change replaces a failing third-party download step with an apt-based installation; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 AI Review & Build Compliance ✅Status: AI analysis complete • Build rules validated • Ready for review 📊 View detailed analysis results🛡️ Analysis Complete
📋 Ready for Merge When
🤖 AI analysis complete - check individual code comments for specific feedback |
There was a problem hiding this comment.
Pull request overview
This PR stabilizes CI by removing a brittle third-party setup-ffmpeg action dependency and installing FFmpeg directly from the GitHub-hosted runner’s apt repositories, preventing upstream release asset issues from breaking all PR workflows.
Changes:
- Replaced
AnimMouse/setup-ffmpeg@v1withapt-get install ffmpegin thetest,build-check, andquality-gatejobs. - Added explanatory comments documenting why apt install is preferred for CI reliability.
Suppressed comments (2)
.github/workflows/ci.yml:207
- The failure message here still references the removed
setup-ffmpegaction, which will mislead debugging now that ffmpeg is installed viaapt-get.
- name: Install ffmpeg
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends ffmpeg
.github/workflows/ci.yml:288
- The failure message here still references the removed
setup-ffmpegaction, which will mislead debugging now that ffmpeg is installed viaapt-get.
- name: Install ffmpeg
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends ffmpeg
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - name: Install ffmpeg | ||
| uses: AnimMouse/setup-ffmpeg@v1 | ||
| with: | ||
| # Pin to a known-good release. The default (latest → FFmpeg 8.1) | ||
| # BtbN/FFmpeg-Builds Linux asset is currently corrupt and fails the | ||
| # job at download ("xz: File format not recognized"). Revert once | ||
| # upstream republishes a valid 8.1 build. | ||
| version: "7.1" | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y --no-install-recommends ffmpeg |
There was a problem hiding this comment.
Fixed in 6f83923: the ffmpeg install and verify steps were removed from ci.yml, so no failure message mentions setup-ffmpeg any more; a comment records why ffmpeg is not installed there.
Review SummaryDecision: ✅ APPROVED AnalysisThis PR modifies only Change Impact
Why This Is Safe
Review ScopeReviewed as CI workflow infrastructure change. Notable that this is outside typical source code review scope since it doesn't modify TypeScript/JavaScript logic, APIs, or user-facing behavior. No issues found. This is a safe, well-reasoned infrastructure improvement that addresses a real problem with the current CI setup. |
…oader The setup-ffmpeg action fetches release assets from another repository, and that has broken this pipeline twice. First the 8.1 asset was published corrupt and every job failed at download with "xz: File format not recognized"; the workaround pinned 7.1. Now the 7.1 pin no longer resolves either, and the step exits 2 immediately after the release id lookup, taking test, build-check and the quality gate down with it. Neither failure originated in this repository, and both blocked every open pull request until someone noticed and patched CI. Installs from the runner's package index instead. The available version is new enough for what the media suites exercise, the runners already carry the index, and an upstream release being moved, rebuilt or rate-limited can no longer take the pipeline down.
e375f82 to
93e1bbc
Compare
🤖 AI Review & Build Compliance ✅Status: AI analysis complete • Build rules validated • Ready for review 📊 View detailed analysis results🛡️ Analysis Complete
📋 Ready for Merge When
🤖 AI analysis complete - check individual code comments for specific feedback |
|
🎉 This PR is included in version 11.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
CI is currently red on every open pull request, and not because of anything in the code.
AnimMouse/setup-ffmpegdownloads release assets from another repository, and that dependency has now broken this pipeline twice:xz: File format not recognized. The workaround pinnedversion: "7.1", with a comment to revert once upstream republished.test,build-checkand the quality gate down with it in about 20 seconds.Reproduced on #1341: all three jobs failed at
Install ffmpeg, twice, including after a re-run.This replaces all three copies of the step with an apt install. The version in the runner's package index is new enough for what the media suites exercise, the index is already on the image, and an upstream release being moved, rebuilt or rate-limited can no longer take the pipeline down.
The fix validates itself: if this PR's own CI goes green, the step works.
Summary by CodeRabbit