-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the tab renderer to allow adding closable tab #6477
Conversation
packages/tree-extension/src/index.ts
Outdated
@@ -3,19 +3,19 @@ | |||
|
|||
import { | |||
JupyterFrontEnd, | |||
JupyterFrontEndPlugin | |||
JupyterFrontEndPlugin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these prettier changes added automatically on commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally the local dev install should pull the right version of prettier
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I couldn't commit because of prettier check, so I ran jlpm prettier
and add the changes.
But the command did have change a lot of files, with the same kind of modification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to do a clean local install in a new environment to make sure the right dependencies are pulled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtpio, I had some weird files in node-modules/.bin
.
jlpm clean
did the trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR add a
close
icon on new closable tab intree-extension
.Fix #6476