Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Settings Editor to the landing page #6316

Merged
merged 14 commits into from
Jan 13, 2023
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 18, 2022

This adds the Settings Editor to the existing TabPanel on the landing page (/tree):

settings-editor.mp4

Previous iteration

setting-editor.mp4

TODO

@jtpio jtpio added this to the 7.0 milestone Mar 18, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/settings-editor

@jtpio
Copy link
Member Author

jtpio commented Mar 18, 2022

Expose the tab panel for other plugins:

Maybe this would actually be a more sustainable approach for the first 7.0 release. So other types of JupyterLab widgets could be added to that tree panel, so they are all under /tree. Instead of trying to have a generic way to open widgets in new browser tabs?

@jtpio
Copy link
Member Author

jtpio commented Mar 20, 2022

Maybe this would actually be a more sustainable approach for the first 7.0 release. So other types of JupyterLab widgets could be added to that tree panel, so they are all under /tree. Instead of trying to have a generic way to open widgets in new browser tabs?

Looks like this could indeed play nicely, especially since it would be similar to how some extra functionalities were being added to the classic notebook before, for example "Clusters" and "Nbextensions":

image

@jtpio jtpio closed this Jan 12, 2023
@jtpio jtpio reopened this Jan 12, 2023
@jtpio
Copy link
Member Author

jtpio commented Jan 12, 2023

Maybe we can keep the settings editor hidden for now by default, so it looks more like the classic notebook.

And add it to the tab panel when opening it via the menu entry:

settings-editor.mp4

@jtpio jtpio marked this pull request as ready for review January 12, 2023 17:49
@jtpio
Copy link
Member Author

jtpio commented Jan 12, 2023

There is an upstream issue when using the command palette.

Tracked in jupyterlab/jupyterlab#13760 and related PR: jupyterlab/jupyterlab#13761

@jtpio
Copy link
Member Author

jtpio commented Jan 12, 2023

There is an upstream issue when using the command palette.

Opened #6691 to track this.

@jtpio
Copy link
Member Author

jtpio commented Jan 12, 2023

Now looking good for a first step. We can continue iterating in follow-up PRs.

@jtpio jtpio merged commit df4a6bf into jupyter:main Jan 13, 2023
@jtpio jtpio deleted the settings-editor branch January 13, 2023 07:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant