Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for windows/python<3.7 #77

Merged
merged 1 commit into from
May 30, 2020
Merged

Fix for windows/python<3.7 #77

merged 1 commit into from
May 30, 2020

Conversation

davidbrochart
Copy link
Member

This patches python's subprocess module as it is done in python/cpython#15706.
We suspect #73 is due to https://bugs.python.org/issue37380, but the fix was not back-ported to python<3.7.

@davidbrochart davidbrochart mentioned this pull request May 30, 2020
Closed
@davidbrochart
Copy link
Member Author

This seems to solve the OSError: [WinError 6] The handle is invalid error.

@davidbrochart davidbrochart mentioned this pull request May 30, 2020
Closed
@MSeal MSeal merged commit 3e2e2f6 into jupyter:master May 30, 2020
@MSeal
Copy link
Contributor

MSeal commented May 30, 2020

Thanks @davidbrochart !

@davidbrochart davidbrochart deleted the fix_win3.6 branch May 31, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidbrochart @MSeal @choldgraf