Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support windows/python<3.7 #239

Closed
davidbrochart opened this issue May 30, 2020 · 1 comment
Closed

Support windows/python<3.7 #239

davidbrochart opened this issue May 30, 2020 · 1 comment

Comments

@davidbrochart
Copy link
Contributor

We are having the same issue with the OSError: [WinError 6] The handle is invalid over in nb_client. It turns out the patch looks quite simple (python/cpython#15706), and it seems that applying it for python<3.7 works (see jupyter/nbclient#77).
Maybe we could also have it in juyter_server and regain compatibility with python3.5 and 3.6 on windows?
@davidbrochart davidbrochart mentioned this issue Jun 2, 2020
Merged
@Zsailer
Copy link
Member

Zsailer commented Jun 2, 2020

fixed in #240.

@Zsailer Zsailer closed this as completed Jun 2, 2020
Zsailer added a commit to Zsailer/jupyter_server that referenced this issue Nov 18, 2022
@Zsailer
random id to traceId headers (jupyter-server#239)
41804d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zsailer @davidbrochart