Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass in a logger to get_metadata #1176

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Pass in a logger to get_metadata #1176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jupyter_server/extension/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def load(self, serverapp):
return loader(serverapp)


class ExtensionPackage(HasTraits):
class ExtensionPackage(LoggingConfigurable):
"""An API for interfacing with a Jupyter Server extension package.

Usage:
Expand All @@ -172,7 +172,7 @@ def _validate_name(self, proposed):
name = proposed["value"]
self._extension_points = {}
try:
self._module, self._metadata = get_metadata(name)
self._module, self._metadata = get_metadata(name, self.log)
except ImportError as e:
msg = (
f"The module '{name}' could not be found ({e}). Are you "
Expand Down