Pass in a logger to get_metadata #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the log messages printed in jupyter-server#1171 don't actually make it out. Whoops! LoggingConfigurable inherits from HasTraits, and sets up Logging appropriately so we can have a log passed through.
Codecov ReportBase: 79.32% // Head: 80.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1176 +/- ##
==========================================
+ Coverage 79.32% 80.04% +0.72%
==========================================
Files 68 68
Lines 8153 8153
Branches 1606 1606
==========================================
+ Hits 6467 6526 +59
+ Misses 1262 1200 -62
- Partials 424 427 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kevin-bates
approved these changes
Jan 14, 2023
There was a problem hiding this comment.
Looks good @yuvipanda. I had run into this when checking this out yesterday. Thanks for circling back!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the log messages printed in
#1171 don't actually make it out. Whoops!
LoggingConfigurable inherits from HasTraits, and sets up Logging appropriately so we can have a log passed through.