Skip to content

Conversation

@junrushao
Copy link
Owner

No description provided.

driazati and others added 6 commits October 24, 2022 17:17
This changes the 'View Source' button on the top right of each doc page
to a link that goes to a GitHub web editor for that docs page and
automatically routes to the right source of truth, be it `.rst` or
`.py`.

Co-authored-by: driazati <[email protected]>
* [Relay] Rewrite division by constant to multiply

Convert division by a scalar constant into multiplication by the inverse
of the constant. Multiplication is faster than division and also allow
for more optimization opportunities. Only applies to float32 and
float64.

* formatting

* handle division by zero

* handle float16
@junrushao junrushao force-pushed the feature/2022-10-10/autotvm-debug branch from 845762c to 888fc75 Compare October 25, 2022 17:21
@junrushao junrushao closed this Oct 25, 2022
junrushao pushed a commit that referenced this pull request Feb 8, 2023
junrushao pushed a commit that referenced this pull request Feb 8, 2023
…pache#321)

With the introduction of structure info in apache#314, the well-formedness check will report malformed whenever an Expr doesn’t have defined structure info.

However, when writing tests for well-formedness check and normalizer, usually we will manually construct the Exprs, which means their structure info are not defined most of the time. As a consequence, the well-formedness check will always complain “the Expr xxx doesn’t have structure info populated.” Therefore, when the checker fails to complain about the original reason of malformed, which means the checker is not working, the tests will still pass and we won’t be able to realize there is something wrong with the checker.

Thus, in this PR we add an optional flag to the well-formedness check. In well-formedness tests, we will turn off the structure info check so that the original reason of being malformed will be revealed correctly.

---

This PR also cleans up the DiagnosticContext parameter in the WellFormed API - the diag_ctx has been unused since the merge of #99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants