-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[TVMScript] TIR parser #13190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TVMScript] TIR parser #13190
Conversation
This PR introduces parser for TIR as part of apache#12442 Co-authored-by: yongwww <[email protected]>
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MasterJH5574
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @cyx-6 for the upstreaming effort!
|
Thanks for the great contribution! I recognize that most of the TIR syntax have been covered by the IRBuilder tests accordingly, for example, This decoupling approach is great because it largely simplifies testing effort, avoids end-to-end integration tests and favors more fine grained unittests. Therefore, given this PR is tested against all the nuanced cases not covered by the IRBuilder tests, so i would say the test coverage is good enough. On the other hand, I do think it’s desirable for us to see some end-to-end tests to make sure the parser is functioning properly, especially when e2e tests are running super fast for in the parser. A couple of test cases I would love to see in a follow-up PR:
Would be great if we could have a follow-up PR for such tests! Thanks a lot! |
|
@junrushao Thanks for bring it up! I agree that it makes sense to follow up with more comprehensive test cases. |
This PR introduces parser for TIR as part of #12442
Co-authored-by: yongwww [email protected]