fix(display): render provider names correctly in Models views - #763
Merged
Conversation
Provider names rendered inconsistently: the CLI `models` report printed the raw provider id (e.g. "openai", "opencode", "google-vertex"), and the shared provider display mapper's fallback was a naive capitalize-first that produced "Google-vertex" / "Kimi-for-coding". - get_provider_display_name: add explicit brand-family handling (openai* -> OpenAI, kimi* -> Kimi, google-vertex/google_vertex -> Google Vertex) and replace the capitalize-first fallback with a word-splitting title-caser (splits on -/_/space, per-word acronym map: AI/GPT/API/LLM/xAI/Vertex), so unknown multi-word providers like `some-new-provider` -> "Some New Provider". - Route the 6 raw entry.provider cells in run_models_report through the mapper so the CLI matches the TUI (which already used it). Adds unit tests for all four reported cases (openai->OpenAI, kimi-for-coding->Kimi, google-vertex->Google Vertex, opencode->OpenCode) plus brand families, both google-vertex spellings, the smart fallback, acronym words, known regressions, and empty/separator-only edges. Confidence: high Scope-risk: narrow
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b544dd287
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+398
to
+399
| if lower.starts_with("openai") { | ||
| return "OpenAI".to_string(); |
There was a problem hiding this comment.
When a row merges multiple providers, aggregate_model_usage_entries stores them as a comma-separated string for every grouping except ClientProviderModel; this mapper now treats the whole string as one provider. In a real Models row such as the same model used via openai and openrouter, the sorted provider value becomes openai, openrouter, this prefix branch returns only OpenAI, and the Providers column silently drops openrouter. Split entry.provider on ", " and map each provider before joining, or make this helper list-aware.
Useful? React with 👍 / 👎.
junhoyeo
added a commit
that referenced
this pull request
Jun 22, 2026
fix(display): map each provider in merged Models rows
aggregate_model_usage_entries joins multiple providers for a row as a
", "-separated string (e.g. "openai, openrouter") for every grouping except
ClientProviderModel. get_provider_display_name treated the whole string as one
provider, so a brand prefix/contains branch (openai*/kimi*/*copilot*) matched
the first segment and silently dropped the rest ("openai, openrouter" rendered
as just "OpenAI").
Split on ", ", map each segment via a new map_single_provider helper, then
rejoin, so "openai, openrouter" -> "OpenAI, OpenRouter". Also adds an explicit
openrouter -> "OpenRouter" arm.
Addresses the P2 review note on #763.
Confidence: high
Scope-risk: narrow
makoMakoGo
added a commit
to makoMakoGo/tokscale
that referenced
this pull request
Jun 23, 2026
ported from upstream junhoyeo#760 ported from upstream junhoyeo#762 ported from upstream junhoyeo#763 ported from upstream junhoyeo#764
t1000040
pushed a commit
to tmobi-internal/tokscale
that referenced
this pull request
Jun 30, 2026
…eo#763) fix(display): render provider names correctly across Models views Provider names rendered inconsistently: the CLI `models` report printed the raw provider id (e.g. "openai", "opencode", "google-vertex"), and the shared provider display mapper's fallback was a naive capitalize-first that produced "Google-vertex" / "Kimi-for-coding". - get_provider_display_name: add explicit brand-family handling (openai* -> OpenAI, kimi* -> Kimi, google-vertex/google_vertex -> Google Vertex) and replace the capitalize-first fallback with a word-splitting title-caser (splits on -/_/space, per-word acronym map: AI/GPT/API/LLM/xAI/Vertex), so unknown multi-word providers like `some-new-provider` -> "Some New Provider". - Route the 6 raw entry.provider cells in run_models_report through the mapper so the CLI matches the TUI (which already used it). Adds unit tests for all four reported cases (openai->OpenAI, kimi-for-coding->Kimi, google-vertex->Google Vertex, opencode->OpenCode) plus brand families, both google-vertex spellings, the smart fallback, acronym words, known regressions, and empty/separator-only edges. Confidence: high Scope-risk: narrow
t1000040
pushed a commit
to tmobi-internal/tokscale
that referenced
this pull request
Jun 30, 2026
) fix(display): map each provider in merged Models rows aggregate_model_usage_entries joins multiple providers for a row as a ", "-separated string (e.g. "openai, openrouter") for every grouping except ClientProviderModel. get_provider_display_name treated the whole string as one provider, so a brand prefix/contains branch (openai*/kimi*/*copilot*) matched the first segment and silently dropped the rest ("openai, openrouter" rendered as just "OpenAI"). Split on ", ", map each segment via a new map_single_provider helper, then rejoin, so "openai, openrouter" -> "OpenAI, OpenRouter". Also adds an explicit openrouter -> "OpenRouter" arm. Addresses the P2 review note on junhoyeo#763. Confidence: high Scope-risk: narrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes provider display names that rendered raw or mis-cased: openai → OpenAI, kimi-for-coding → Kimi, google-vertex → Google Vertex, opencode → OpenCode.
Root cause
Two layers:
modelsreport rendered the raw provider id (Cell::new(&entry.provider)) in 6 places — so you sawopenai/opencode/google-vertexverbatim.get_provider_display_namemapper's fallback was a naive capitalize-first, producingGoogle-vertex/Kimi-for-codingfor hyphenated ids.Fix
get_provider_display_name): brand-family prefixes (openai*→OpenAI,kimi*→Kimi, copilot→GitHub Copilot), explicitgoogle-vertex/google_vertex→"Google Vertex" (both spellings, sincecanonical_providerrewrites the hyphen to an underscore), and a smart title-case fallback that splits on-/_/space with a per-word acronym map (AI, GPT, API, LLM, xAI, Vertex). Unknown multi-word providers likesome-new-providernow render "Some New Provider".run_models_reportthrough the mapper, so the CLI matches the TUI (which already used it). Confirmed no other raw-provider cell renders remain.Tests (all green)
8 new unit tests covering the four reported cases, openai/kimi families, both google-vertex spellings, the smart multi-word fallback, per-word acronyms, known-brand regressions (Anthropic/xAI/DeepSeek/GitHub Copilot/…), and empty/separator-only edges.
cargo build/test/clippy/fmt --checkall pass (730 + 122 tests).Summary by cubic
Fixes provider names across Models views so brands render correctly and consistently (e.g., openai → OpenAI, kimi-for-coding → Kimi, google-vertex → Google Vertex). The CLI now matches the TUI, and unknown ids get clean title-casing.
entry.providercells in themodelsreport throughget_provider_display_name.get_provider_display_namewith brand-family rules (openai*,kimi*, Copilot variants) and explicitgoogle-vertex/google_vertex→ Google Vertex.Written for commit 3b544dd. Summary will update on new commits.