fix(tui): color Fable models in the Anthropic palette like Opus - #762
Merged
Conversation
Fable is a Claude model family, but neither `inferred_provider_from_model`
(core) nor `get_provider_from_model` (TUI) recognized the `fable` token —
only `claude`/`opus`/`sonnet`/`haiku`. As a result a bare `fable-5` id was
attributed to the "unknown" provider and rendered with the gray
UNKNOWN_SHADES in the Overview tab instead of the Anthropic orange that
Opus gets. (The `claude-fable-5` form happened to match via "claude", so
the bug only bit the bare/normalized forms.)
Add `fable` to the Anthropic branch in both functions so every Fable form
maps to Anthropic and shares the same base color/level as Opus.
Tests: provider_identity maps fable-5 / claude-fable-5 / claude-fable-5[1m]
to "anthropic"; get_provider_from_model recognizes fable; and
get_model_color("fable-5") == get_model_color("claude-opus-4-1") (and != the
unknown shade).
Confidence: high
Scope-risk: narrow
Not-tested: exact cost-ranked shade in build_model_shade_map (the base-color level is asserted; within-provider shade remains cost-ranked by design)
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Address automated review feedback on PR #762. P2: get_provider_from_model used a raw substring match for "fable", which could misclassify unrelated names (e.g. "unfabled-x") as Anthropic and drift from core inference. Match "fable" only as a delimited token, mirroring core provider_identity::contains_delimited. P3: fable_gets_same_base_color_as_opus asserted default-palette color inequality against an unknown model, which a user's ~/.tokscale color override could break. Assert provider classification instead, which is config-independent. Constraint: get_provider_from_model is a TUI-local mapping with a wider provider set than core, so fix is applied locally rather than reusing core's private contains_delimited. Rejected: Re-export core contains_delimited | larger surface than needed Confidence: high Scope-risk: narrow
…ic-color # Conflicts: # crates/tokscale-cli/src/tui/ui/widgets.rs
makoMakoGo
added a commit
to makoMakoGo/tokscale
that referenced
this pull request
Jun 23, 2026
ported from upstream junhoyeo#760 ported from upstream junhoyeo#762 ported from upstream junhoyeo#763 ported from upstream junhoyeo#764
t1000040
pushed a commit
to tmobi-internal/tokscale
that referenced
this pull request
Jun 30, 2026
…oyeo#762) * fix(tui): color Fable models in the Anthropic palette like Opus Fable is a Claude model family, but neither `inferred_provider_from_model` (core) nor `get_provider_from_model` (TUI) recognized the `fable` token — only `claude`/`opus`/`sonnet`/`haiku`. As a result a bare `fable-5` id was attributed to the "unknown" provider and rendered with the gray UNKNOWN_SHADES in the Overview tab instead of the Anthropic orange that Opus gets. (The `claude-fable-5` form happened to match via "claude", so the bug only bit the bare/normalized forms.) Add `fable` to the Anthropic branch in both functions so every Fable form maps to Anthropic and shares the same base color/level as Opus. Tests: provider_identity maps fable-5 / claude-fable-5 / claude-fable-5[1m] to "anthropic"; get_provider_from_model recognizes fable; and get_model_color("fable-5") == get_model_color("claude-opus-4-1") (and != the unknown shade). Confidence: high Scope-risk: narrow Not-tested: exact cost-ranked shade in build_model_shade_map (the base-color level is asserted; within-provider shade remains cost-ranked by design) * fix(tui): match fable as delimited token + make color test hermetic Address automated review feedback on PR junhoyeo#762. P2: get_provider_from_model used a raw substring match for "fable", which could misclassify unrelated names (e.g. "unfabled-x") as Anthropic and drift from core inference. Match "fable" only as a delimited token, mirroring core provider_identity::contains_delimited. P3: fable_gets_same_base_color_as_opus asserted default-palette color inequality against an unknown model, which a user's ~/.tokscale color override could break. Assert provider classification instead, which is config-independent. Constraint: get_provider_from_model is a TUI-local mapping with a wider provider set than core, so fix is applied locally rather than reusing core's private contains_delimited. Rejected: Re-export core contains_delimited | larger surface than needed Confidence: high Scope-risk: narrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Color Fable models the same as Opus in the Overview tab
Problem
In the TUI Overview tab, Anthropic models are colored from
ANTHROPIC_SHADES(the orange palette). But Fable models rendered gray (theUNKNOWN_SHADESfallback) instead of the Anthropic color Opus gets.Root cause
Two functions classify a model's provider, and neither recognized the
fabletoken — onlyclaude/opus/sonnet/haiku:crates/tokscale-core/src/provider_identity.rs—inferred_provider_from_model(drives attribution/grouping app-wide)crates/tokscale-cli/src/tui/ui/widgets.rs—get_provider_from_model(TUI color fallback)The
claude-fable-5form slipped through via the"claude"substring, but the bare/normalizedfable-5form (which the pricing layer already produces) fell through to"unknown"→ gray.Fix
Add
fableto the Anthropic branch in both functions. Now every Fable form (fable-5,claude-fable-5,claude-fable-5[1m]) maps toanthropicand shares the same base color/level as Opus.Tests
provider_identity: all three Fable forms →Some("anthropic").get_provider_from_model("fable-5") == "anthropic".get_model_color("fable-5") == get_model_color("claude-opus-4-1")and!=the unknown shade.Note
Within the Anthropic palette the exact shade is cost-ranked by design (rank 0 = highest-cost = base orange), so a Fable and an Opus model still differentiate by cost when both are present — this PR fixes the family/base-level (no longer gray). If you'd prefer Fable pinned to Opus's exact shade regardless of cost, that's a separate design change — happy to follow up.
🤖 Generated with Claude Code
Summary by cubic
Fable models now render in the Anthropic palette (like Opus) in the TUI Overview. We recognize
fableas a delimited token so barefable-5is orange and unrelated names aren’t misclassified.fableto the Anthropic branch ininferred_provider_from_model(@tokscale-core) andget_provider_from_model(@tokscale-cli).fable-5,claude-fable-5,claude-fable-5[1m]) map toanthropicand share Opus’s base color; within-provider shade stays cost-ranked.fableonly as a delimited token in the TUI and add tests for inference, color mapping, and substring regressions; make the color test config-independent.Written for commit ff3b907. Summary will update on new commits.