Skip to content

inbounds for is_strictly_increasing #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 3 commits into from
May 9, 2021
Merged

inbounds for is_strictly_increasing #1325

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d1bec6
inbounds for is_strictly_increasing
blegat May 9, 2021
1891b28
Suggested improved implementation
blegat May 9, 2021
a6cb62d
Add @inbounds
blegat May 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/Utilities/functions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,25 +660,30 @@ function is_canonical(f::Union{SQF,VQF})
end

"""
is_strictly_sorted(x::AbstractVector, by, filter)
is_strictly_sorted(x::Vector, by, filter)

Returns `true` if `by(x[i]) < by(x[i + 1])` and `filter(x[i]) == true` for
all indices i.
"""
function is_strictly_sorted(x::AbstractVector, by, filter)
function is_strictly_sorted(x::Vector, by, filter)
if isempty(x)
return true
end
if !filter(first(x))
@inbounds current_x = first(x)
if !filter(current_x)
return false
end
current_fx = by(current_x)
for i in eachindex(x)[2:end]
if by(x[i]) <= by(x[i-1])
@inbounds next_x = x[i]
if !filter(next_x)
return false
end
if !filter(x[i])
next_fx = by(next_x)
if next_fx <= current_fx
return false
end
current_x, current_fx = next_x, next_fx
end
return true
end
Expand Down