Pass copy operation for non-variable constraints #1286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
force-pushed
the
bl/pass_cons
branch
3 times, most recently
from
6e336e8 to
c26a6cd
Compare
Merged
Member
|
Any benchmarks? |
odow
approved these changes
Mar 21, 2021
Member
Author
|
I don't believe this will provide any gain yet but once we have #1287, it will allow efficient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
constraintsfield of the model has a more efficient copy_to than adding constraints one by one (e.g. SparseMatrixCSC) then even if it's behind layers of bridges, CachingOptimizer and UniversalFallback, it should be copied (if not bridged), not added one by one.This PR addresses that.
See #1261
Requires #1267