More flexible Model with StructOfConstraints #1267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
force-pushed
the
bl/vector_of_constraints
branch
from
bb970bf to
ddf9fe7
Compare
blegat
force-pushed
the
bl/struct_of_constraints
branch
3 times, most recently
from
86eabef to
72eeb41
Compare
blegat
force-pushed
the
bl/vector_of_constraints
branch
from
ddf9fe7 to
3c29f6b
Compare
blegat
force-pushed
the
bl/struct_of_constraints
branch
from
6ea998c to
50319cf
Compare
7 tasks
odow
force-pushed
the
bl/vector_of_constraints
branch
from
3c29f6b to
8afdfe2
Compare
blegat
force-pushed
the
bl/struct_of_constraints
branch
from
50319cf to
86138da
Compare
3 tasks
odow
reviewed
Mar 14, 2021
Member
odow
left a comment
odow
left a comment
There was a problem hiding this comment.
Do we have some benchmarks for obvious performance regressions?
Merged
odow
approved these changes
Mar 17, 2021
Member
odow
left a comment
odow
left a comment
There was a problem hiding this comment.
I ran the benchmarks. They're slightly slower, but I can tidy up after you've finished making large changes. It's probably just the precompile statements that need tweaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the code of
AbstractModelto make it more versatile.Instead of having one field for each function type which contains a struct with one field for each set type, it now has a field
constraintsthat contains one field for each function type, ...As discussed in #1261, by changing the type of the
constraintsfield, we can now target many more types of models.The base is set to #1245 so that it shows the diff with that PR but this is going to be merged to master once #1245 is merged.
StructOfConstraintsinstead of adding them as type parameter as otherwise the type can be huge. This option will be used by@model.StructOfConstraint