Add infeasibility certificate back #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 56.33% 56.15% -0.19%
==========================================
Files 9 9
Lines 813 821 +8
==========================================
+ Hits 458 461 +3
- Misses 355 360 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This was referenced Mar 23, 2023
blegat
added a commit
to jump-dev/SumOfSquares.jl
that referenced
this pull request
Mar 23, 2023
They are fixed by jump-dev/CSDP.jl#89
blegat
added a commit
to jump-dev/SumOfSquares.jl
that referenced
this pull request
Mar 25, 2023
* Variable-wise bounds for putinar * Fixes * Fix * Fixes * Exclude sparsity tests * Fixes * Fix format * Fix * Fixes * Fix * Update solver failing tests * Fix format * Reenable CSDP tests They are fixed by jump-dev/CSDP.jl#89 * Fixes * Fix certificate example CSDP fails because an empty constraint is added * Remove polynomial optimization tutorial * Fix doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I seems that was commented out in #81 so that MOI does not test the objective value at the infeasibility certificates because of jump-dev/MathOptInterface.jl#1759.
However, the certificate at the value was correct so this was quite breaking.
Actually, thanks to jump-dev/MathOptInterface.jl#1893, we can now throw an error that is handled by the CachingOptimizer so we can pass these tests now!
I also enabled many other tests that were passing on my computer