Refactor src and test MOI_wrappers for style and clarity #81
Conversation
Codecov ReportBase: 55.58% // Head: 55.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 55.58% 55.98% +0.40%
==========================================
Files 9 9
Lines 833 827 -6
==========================================
Hits 463 463
+ Misses 370 364 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I thought going through the code might help me spot any glaring errors. But the failures on mac seem sporadic. Local test failures seem random and are not reproducible. |
| }, | ||
| ) | ||
| MOI.check_result_index_bounds(model, attr) | ||
| # TODO(odow): this isn't correct. In Ax = b, it should be Ax, not b. |
There was a problem hiding this comment.
Does removing this method work now that we have jump-dev/MathOptInterface.jl#1674 ?
There was a problem hiding this comment.
Yes, we should be able to do something like that. I avoided making large changes in this PR though.
|
Merging because I have a few follow-up PRs that change things other than style. |
No description provided.