Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Method Constants #256

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Using Method Constants #256

merged 1 commit into from
Sep 14, 2019

Conversation

JeremyLoy
Copy link
Contributor

No description provided.

@JeremyLoy
Copy link
Contributor Author

go vet ./... @ Go Tip failed in travis.

Not sure why, go vet ./... works locally for me with Go 1.11.1

@SamWhited
Copy link

Go vet did not fail, the tests did:

--- FAIL: TestTreeFindCaseInsensitivePath (0.00s)
    tree_test.go:532: Route '/u/äpfêl/' not found!
    tree_test.go:532: Route '/u/öpfêl' not found!
    tree_test.go:532: Route '/v/Äpfêl/' not found!
    tree_test.go:532: Route '/v/Öpfêl' not found!
    tree_test.go:532: Route '/w/♬' not found!
    tree_test.go:532: Route '/w/♭/' not found!
    tree_test.go:532: Route '/w/𠜎' not found!
    tree_test.go:532: Route '/w/𠜏/' not found!
    tree_test.go:541: Route '/u/äpfêl/' not found!
    tree_test.go:541: Route '/u/öpfêl' not found!
    tree_test.go:541: Route '/v/Äpfêl/' not found!
    tree_test.go:541: Route '/v/Öpfêl' not found!
    tree_test.go:541: Route '/w/♬' not found!
    tree_test.go:541: Route '/w/♭/' not found!
    tree_test.go:541: Route '/w/𠜎' not found!
    tree_test.go:541: Route '/w/𠜏/' not found!
    tree_test.go:613: Wrong result for '/u/ÄPFÊL/': got /, false; want /u/äpfêl/, true

@julienschmidt
Copy link
Owner

julienschmidt commented Oct 15, 2018 •
edited
Loading

Working on it, something changed in go tip with the handling of unicode (specifically the handling of invalid codepoints)

@JeremyLoy
Copy link
Contributor Author

ah I see. My mistake.

@SamWhited
Copy link

@julienschmidt that's likely to be golang/go@f74de24 if it helps

@QuLogic
Copy link

QuLogic commented Feb 17, 2019

Re: test failure, see also #263.

@julienschmidt julienschmidt merged commit 90ef33e into julienschmidt:master Sep 14, 2019
similark pushed a commit to similarweb/httprouter that referenced this pull request May 9, 2023
@arschles @tomkerkhove
adding Ajanth as a code owner (julienschmidt#256)
27612da 
Signed-off-by: Aaron Schlesinger <[email protected]>

Co-authored-by: Tom Kerkhove <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienschmidt julienschmidt julienschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeremyLoy @SamWhited @julienschmidt @QuLogic