Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go1.12 strings.Map breaks package usage of strings.ToLower #263

Closed
cybrcodr opened this issue Jan 9, 2019 · 1 comment
Closed

Go1.12 strings.Map breaks package usage of strings.ToLower #263

cybrcodr opened this issue Jan 9, 2019 · 1 comment
Labels
Milestone

Comments

@cybrcodr
Copy link

cybrcodr commented Jan 9, 2019

Heads up. Go1.12 CL https://golang.org/cl/131495 will break this package's use of strings.ToLower calls. This is exhibited in the following test failure ...

$ go version
go version go1.12beta1 linux/386
$ go test
--- FAIL: TestTreeFindCaseInsensitivePath (0.00s)
    tree_test.go:532: Route '/u/äpfêl/' not found!
    tree_test.go:532: Route '/u/öpfêl' not found!
    tree_test.go:532: Route '/v/Äpfêl/' not found!
    tree_test.go:532: Route '/v/Öpfêl' not found!
    tree_test.go:532: Route '/w/♬' not found!
    tree_test.go:532: Route '/w/♭/' not found!
    tree_test.go:532: Route '/w/𠜎' not found!
    tree_test.go:532: Route '/w/𠜏/' not found!
    tree_test.go:541: Route '/u/äpfêl/' not found!
    tree_test.go:541: Route '/u/öpfêl' not found!
    tree_test.go:541: Route '/v/Äpfêl/' not found!
    tree_test.go:541: Route '/v/Öpfêl' not found!
    tree_test.go:541: Route '/w/♬' not found!
    tree_test.go:541: Route '/w/♭/' not found!
    tree_test.go:541: Route '/w/𠜎' not found!
    tree_test.go:541: Route '/w/𠜏/' not found!
    tree_test.go:613: Wrong result for '/u/ÄPFÊL/': got /, false; want /u/äpfêl/, true
FAIL
exit status 1
@julienschmidt
Copy link
Owner

Fixed by 667c1db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants