add / update fstab entry with --update-fstab

[timfeirg]

• abs path check for sqlite and similars
• correctly handle slice arguments, even though they don't exist in juicefs mount yet
• do not run in containers
• unit tests

PR code will produce the following result:

permission denied behavior:

closes #2432

[codecov-commenter]

Codecov Report

Merging #2462 (97f35f2) into main (b1e5ebf) will decrease coverage by 1.78%.
The diff coverage is 53.19%.

❗ Current head 97f35f2 differs from pull request most recent head f77b909. Consider uploading reports for the commit f77b909 to get more accurate results

@@            Coverage Diff             @@
##             main    #2462      +/-   ##
==========================================
- Coverage   61.52%   59.73%   -1.79%     
==========================================
  Files         138      138              
  Lines       25698    23333    -2365     
==========================================
- Hits        15810    13938    -1872     
+ Misses       8030     7583     -447     
+ Partials     1858     1812      -46     

Impacted Files	Coverage Δ
cmd/main.go	45.08% <50.00%> (-2.29%)	⬇️
cmd/mount.go	59.15% <51.13%> (-2.58%)	⬇️
cmd/mount_unix.go	47.22% <100.00%> (-0.53%)	⬇️
pkg/sync/config.go	0.00% <0.00%> (-83.34%)	⬇️
pkg/object/minio.go	61.29% <0.00%> (-15.19%)	⬇️
cmd/sync.go	56.46% <0.00%> (-12.87%)	⬇️
pkg/chunk/utils_linux.go	66.66% <0.00%> (-8.34%)	⬇️
cmd/version.go	42.85% <0.00%> (-7.15%)	⬇️
pkg/utils/utils.go	69.81% <0.00%> (-6.76%)	⬇️
pkg/object/file.go	65.76% <0.00%> (-6.71%)	⬇️
... and 130 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[davies]

Could you also update the docs (command ref and how to mount on boot)

[davies]

this should not fail the mount

[timfeirg]

I usually submit docs update after functionality has been confirmed, I'll work on them now.

[timfeirg]

I wish to resolve #2504 first, and work on docs for this feature later on, in a separate PR.

[timfeirg]

failed tests passed without any code change, if things go poorly in the future, remember that current state is able to PASS.

working on docs now, no code change will be introduced.

[timfeirg]

code change has been introduced since review, take another look at the follow-up commits? @davies

[davies]

This will be available in 1.1 release, but user still read the latest docs, so we should add docs for new feature without replacing the old ways.

For these tutorials, we don't need to change them (keep them simple).

[timfeirg]

the old ways are preserved in guide/mount_at_boot.md, I can add minimum version requirements here (and remove after 1.1 has been widely adopted), would this suffice?

I think putting "the old way" here might just be too much content, after all, there's a dedicated chapter on this topic.

[timfeirg]

For these tutorials, we don't need to change them (keep them simple).

--update-fstab is the simplest way to approach auto-mount, shouldn't we recommend its usage in all tutorials? if version inconsistency is the main issue here, can I postpone this docs update until after 1.1 release?

[davies]

This requires 1.1+

[davies]

Since 1.1 is not released, we should put this new feature at the end of this section.

[timfeirg]

can I create a separate PR for docs update? review suggestions so far are all concerning release planning & version inconsistency, which won't be an issue if we update docs only after 1.1 release, am I correct? @davies

[davies]

If you prefer to have another PR, please revert the changes in docs, and we can merge the feature first.

[timfeirg]

docs part has been moved to #2554