Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add / update fstab entry with --update-fstab #2446

Closed
wants to merge 1 commit into from
Closed

add / update fstab entry with --update-fstab #2446

wants to merge 1 commit into from

Conversation

timfeirg
Copy link
Contributor

@timfeirg timfeirg commented Aug 2, 2022

  • abs path check for sqlite and similars
  • correctly handle slice arguments, even though they don't exist in juicefs mount yet
  • do not run in containers
  • unit tests

PR code will produce the following result:

image

closes #2432

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2022

CLA assistant check
All committers have signed the CLA.

@timfeirg timfeirg marked this pull request as draft August 2, 2022 16:45
@zhijian-pro zhijian-pro added this to the Release 1.1 milestone Aug 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #2446 (d2ffbbc) into main (c274542) will decrease coverage by 0.14%.
The diff coverage is 5.71%.

❗ Current head d2ffbbc differs from pull request most recent head 9df976f. Consider uploading reports for the commit 9df976f to get more accurate results

@@            Coverage Diff             @@
##             main    #2446      +/-   ##
==========================================
- Coverage   61.59%   61.45%   -0.15%     
==========================================
  Files         137      137              
  Lines       25563    25633      +70     
==========================================
+ Hits        15746    15752       +6     
- Misses       7970     8033      +63     
- Partials     1847     1848       +1     
Impacted Files Coverage Δ
cmd/mount.go 49.85% <0.00%> (-11.88%) ⬇️
cmd/mount_unix.go 49.56% <100.00%> (+1.81%) ⬆️
pkg/chunk/utils_unix.go 73.33% <0.00%> (-20.00%) ⬇️
pkg/chunk/disk_cache.go 81.35% <0.00%> (ø)
pkg/meta/redis.go 72.01% <0.00%> (+0.04%) ⬆️
pkg/meta/sql.go 66.00% <0.00%> (+0.09%) ⬆️
pkg/chunk/cached_store.go 77.56% <0.00%> (+0.17%) ⬆️
pkg/meta/tkv_mem.go 88.43% <0.00%> (+0.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@timfeirg timfeirg marked this pull request as ready for review August 3, 2022 09:41
@timfeirg
Copy link
Contributor Author

timfeirg commented Aug 4, 2022

close in favor of #2462

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the automatic mount script
4 participants