[Fix] prop-types: props missing in validation when using generic types from a namespace import

[rbondoc96]

Description

Fixes #3684.

TypeScript code that uses ComponentProps and ComponentPropsWithoutRef from a namespace import (such as import React from 'react' or import * as React from 'react') led to destructured props receiving a "is missing in props validation" error.

For example:

import * as React from 'react';

export const Button = React.forwardRef<HTMLButtonElement, React.ComponentPropsWithoutRef<'button'>>(
    // Error: 'className' is missing in props validation (from the react/prop-types rule)
    ({ children, className, ...props }, ref) => {
        return (
            <button className={className} ref={ref} {...props}>
                {children}
            </button>
        );
    },
);
Button.displayName = 'Button';

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (01ac0a2) to head (b9f70bd).
Report is 31 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3859      +/-   ##
==========================================
- Coverage   97.70%   97.66%   -0.05%     
==========================================
  Files         136      136              
  Lines        9950     9978      +28     
  Branches     3685     3703      +18     
==========================================
+ Hits         9722     9745      +23     
- Misses        228      233       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ljharb]

Thanks, looks great!

[rbondoc96]

Glad I could help 🙂