[Fix] no-unknown-property support new precedence prop
#3829
+27
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Sep 23, 2024
|
@ljharb is there a way to accommodate that in the plugin, or does that just mean not adding it until there is a version of the plugin released only for react v19+? |
|
@acusti there is! see the |
acusti
force-pushed
the
no-unknown-property-precedence
branch
from
f57bd9f to
500112b
Compare
ljharb
reviewed
Oct 22, 2024
ljharb
reviewed
Oct 22, 2024
acusti
force-pushed
the
no-unknown-property-precedence
branch
3 times, most recently
from
df4f665 to
ac007b6
Compare
|
@ljharb now that React v19 stable is released, i can update the version checks and test settings to specify update: i went ahead and made that change because it’s cleaner and simpler and i don’t imagine there will be any need to support react 19 prereleases/RCs in the future. |
acusti
force-pushed
the
no-unknown-property-precedence
branch
4 times, most recently
from
63b0535 to
9bb6f62
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3829 +/- ##
==========================================
- Coverage 97.80% 97.69% -0.11%
==========================================
Files 136 136
Lines 9977 9979 +2
Branches 3699 3700 +1
==========================================
- Hits 9758 9749 -9
- Misses 219 230 +11 ☔ View full report in Codecov by Sentry. |
ljharb
force-pushed
the
no-unknown-property-precedence
branch
from
9bb6f62 to
c948e48
Compare
ljharb
approved these changes
Dec 9, 2024
ljharb
force-pushed
the
no-unknown-property-precedence
branch
from
c948e48 to
66ae4c1
Compare
|
wonderful! thanks for reviewing, refactoring, and merging it. |
cswimr
pushed a commit
to cswimr/gauntlet-cswimr-plugins
that referenced
this pull request
Dec 27, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) | devDependencies | patch | [`7.37.2` -> `7.37.3`](https://renovatebot.com/diffs/npm/eslint-plugin-react/7.37.2/7.37.3) | --- ### Release Notes <details> <summary>jsx-eslint/eslint-plugin-react (eslint-plugin-react)</summary> ### [`v7.37.3`](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7373---20241223) [Compare Source](jsx-eslint/eslint-plugin-react@v7.37.2...v7.37.3) ##### Fixed - \[`no-danger`]: avoid a crash on a nested component name ([#​3833][] [@​ljharb](https://github.com/ljharb)) - \[Fix] types: correct generated type declaration ([#​3840][] [@​ocavue](https://github.com/ocavue)) - \[`no-unknown-property`]: support `precedence` prop in react 19 ([#​3829][] [@​acusti](https://github.com/acusti)) - \[`prop-types`]: props missing in validation when using generic types from a namespace import ([#​3859][] [@​rbondoc96](https://github.com/rbondoc96)) ##### Changed - \[Tests] \[`jsx-no-script-url`]: Improve tests ([#​3849][] [@​radu2147](https://github.com/radu2147)) - \[Docs] fix broken links: \[`default-props-match-prop-types`], \[`jsx-boolean-value`], \[`jsx-curly-brace-presence`], \[`jsx-no-bind`], \[`no-array-index-key`], \[`no-is-mounted`], \[`no-render-return-value`], \[`require-default-props`] ([#​3841][] [@​bastiendmt](https://github.com/bastiendmt)) [7.37.3]: jsx-eslint/eslint-plugin-react@v7.37.2...v7.37.3 [#​3859]: jsx-eslint/eslint-plugin-react#3859 [#​3849]: jsx-eslint/eslint-plugin-react#3849 [#​3841]: jsx-eslint/eslint-plugin-react#3841 [#​3840]: jsx-eslint/eslint-plugin-react#3840 [#​3833]: jsx-eslint/eslint-plugin-react#3833 [#​3829]: jsx-eslint/eslint-plugin-react#3829 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44My40IiwidXBkYXRlZEluVmVyIjoiMzkuODMuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://www.coastalcommits.com/cswimr/gauntlet-cswimr-plugins/pulls/9 Co-authored-by: Renovate <[email protected]> Co-committed-by: Renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3827