[Fix] no-is-mounted: fix logic in method name check
#3821
Merged
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathias-S
force-pushed
the
fix-no-is-mounted-logic
branch
from
9b6b17f
to
7e2520a
Compare
voxpelli
reviewed
Sep 12, 2024
This was referenced Sep 12, 2024
The last change to `no-is-mounted` caused the rule to error with any method name, not just with "isMounted".
Mathias-S
force-pushed
the
fix-no-is-mounted-logic
branch
from
7e2520a
to
07f2c97
Compare
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3821 +/- ##
==========================================
+ Coverage 94.52% 95.97% +1.44%
==========================================
Files 133 136 +3
Lines 9916 9929 +13
Branches 3676 3677 +1
==========================================
+ Hits 9373 9529 +156
+ Misses 543 400 -143 ☔ View full report in Codecov by Sentry. |
1 task
voxpelli
approved these changes
Sep 12, 2024
ljharb
force-pushed
the
fix-no-is-mounted-logic
branch
from
07f2c97
to
a09083b
Compare
lindboe
added a commit
to infinitered/ignite
that referenced
this pull request
Sep 12, 2024
They added a bug, there's a fix but it's unreleased: jsx-eslint/eslint-plugin-react#3821
lindboe
added a commit
to infinitered/ignite
that referenced
this pull request
Sep 12, 2024
…2772) * Initial change of imports to use a unified alias * More import updates to fix router app generation * Lint fix * Update test * Fix demo removal for i18n These lines weren't getting removed in demo and failed tests. Did we not have a test for removing demo and compiling? * Need to also transform test setup file * Lint fix * Print command output when it fails for easier debugging * Need to remove App.tsx when using expo-router * Fix patch removal I'm confused about this one, it appeared to work and printed `patches/patch.patch` originally, but now the path isn't including the directory. So added a new CWD to make sure the file gets deleted, otherwise bun fails. * This only applied for the splashscreen changes ...from the test it was copied from * Add error output to ignite-new test as well * Remove test output change for now Potential issue with buffer size. Update to use spawn later so we can stream output. * Make sure test doesn't time out * Pin eslint react plugin version They added a bug, there's a fix but it's unreleased: jsx-eslint/eslint-plugin-react#3821
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last change to
no-is-mountedcaused the rule to error with any method name, not just with "isMounted".Fixes #3819