[Fix] no-is-mounted: fix logic in method name check

The last change to `no-is-mounted` caused the rule to error with any method name, not just with "isMounted".
jsx-eslint · Sep 12, 2024 · 9b6b17f · 9b6b17f
1 parent 1df23d2
commit 9b6b17f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/rules/no-is-mounted.js b/lib/rules/no-is-mounted.js
@@ -41,7 +41,7 @@ module.exports = {
         }
         if (
           callee.object.type !== 'ThisExpression'
-          && (!('name' in callee.property) || callee.property.name !== 'isMounted')
+          || (!('name' in callee.property) || callee.property.name !== 'isMounted')
         ) {
           return;
         }

diff --git a/tests/lib/rules/no-is-mounted.js b/tests/lib/rules/no-is-mounted.js
@@ -57,6 +57,18 @@ ruleTester.run('no-is-mounted', rule, {
         });
       `,
     },
+    {
+      code: `
+        class Hello extends React.Component {
+          notIsMounted() {}
+          render() {
+            this.notIsMounted();
+            return <div>Hello</div>;
+          }
+        };
+      `,
+      errors: [{ messageId: 'noIsMounted' }],
+    },
   ]),
 
   invalid: parsers.all([