Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] jsx-closing-bracket-location, jsx-no-bind: fix eslint issues #3356

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

caroline223
Copy link
Contributor

No description provided.

@caroline223
Copy link
Contributor Author

@ljharb May you look at my attempted rebase of the code?

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #3356 (be4eb34) into master (cac3838) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head be4eb34 differs from pull request most recent head d000f8c. Consider uploading reports for the commit d000f8c to get more accurate results

@@            Coverage Diff             @@
##           master    #3356      +/-   ##
==========================================
- Coverage   97.54%   97.49%   -0.05%     
==========================================
  Files         123      123              
  Lines        8873     8861      -12     
  Branches     3244     3238       -6     
==========================================
- Hits         8655     8639      -16     
- Misses        218      222       +4     
Impacted Files Coverage Δ
lib/rules/jsx-no-bind.js 100.00% <ø> (ø)
lib/rules/jsx-closing-bracket-location.js 94.48% <100.00%> (ø)
lib/rules/jsx-no-target-blank.js 88.88% <0.00%> (-3.80%) ⬇️
lib/rules/jsx-no-leaked-render.js 98.24% <0.00%> (-0.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately you created a new branch called "edx/master", and pushed to that, and made a PR of it, instead of force pushing to master (the PR branch on #3351).

I've rebased this PR and force pushed it to both branches, so this should be fine.

@ljharb ljharb changed the title Edx/master [Refactor] jsx-closing-bracket-location, jsx-no-bind: fix eslint issues Aug 13, 2022
@ljharb ljharb merged commit d000f8c into jsx-eslint:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants