Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] jsx-closing-bracket-location, jsx-no-bind: fix eslint issues #3351

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

caroline223
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #3351 (eeba9b8) into master (cac3838) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

❗ Current head eeba9b8 differs from pull request most recent head d000f8c. Consider uploading reports for the commit d000f8c to get more accurate results

@@            Coverage Diff             @@
##           master    #3351      +/-   ##
==========================================
- Coverage   97.54%   97.49%   -0.05%     
==========================================
  Files         123      123              
  Lines        8873     8861      -12     
  Branches     3244     3238       -6     
==========================================
- Hits         8655     8639      -16     
- Misses        218      222       +4     
Impacted Files Coverage Δ
lib/rules/jsx-boolean-value.js 100.00% <ø> (ø)
lib/rules/jsx-closing-bracket-location.js 94.48% <66.66%> (ø)
lib/rules/jsx-no-bind.js 100.00% <100.00%> (ø)
lib/rules/jsx-no-target-blank.js 88.88% <0.00%> (-3.80%) ⬇️
lib/rules/jsx-no-leaked-render.js 98.24% <0.00%> (-0.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any eslint overrides being removed, or config being changed?

lib/rules/jsx-no-bind.js Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the master branch 2 times, most recently from be4eb34 to d000f8c Compare August 13, 2022 06:27
@ljharb
Copy link
Member

ljharb commented Aug 13, 2022

Synced with #3356.

@ljharb ljharb changed the title Addressed eslint issues with assignment to function parameter 'correctColumn'. [Refactor] jsx-closing-bracket-location, jsx-no-bind: fix eslint issues Aug 13, 2022
@ljharb ljharb merged commit d000f8c into jsx-eslint:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants