Breaking: Add missing rule schemas #3106
Open
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
missing-rule-schemas
branch
from
7cec124
to
f5a3bb3
Compare
ljharb
reviewed
Oct 18, 2021
|
|
||
| messages | ||
| messages, | ||
| schema: [] |
There was a problem hiding this comment.
i assume these are breaking changes, because it forbids any option to be passed, where previously any option was allowed but ignored?
There was a problem hiding this comment.
Correct. We want to make sure people do not pass garbage/non-existent options to our rules.
bmish
force-pushed
the
missing-rule-schemas
branch
from
1201088
to
52cd580
Compare
ljharb
force-pushed
the
master
branch
6 times, most recently
from
59af733
to
865ed16
Compare
ljharb
force-pushed
the
master
branch
4 times, most recently
from
069314a
to
181c68f
Compare
ljharb
force-pushed
the
master
branch
2 times, most recently
from
380e32c
to
51d342b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforced by eslint-plugin/require-meta-schema after the eslint-plugin-eslint-plugin v4 upgrade (#3105).