fix: remove unnecessary schema from jsx-no-comment-textnodes #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jul 3, 2019
| schema: [{ | ||
| type: 'object', | ||
| properties: {}, | ||
| additionalProperties: false |
There was a problem hiding this comment.
this seems like it'd be a breaking change, in case someone had already been providing an empty object - also, the purpose of this schema is to make it easy for people to add new properties (without being forced to suddenly add the object)
There was a problem hiding this comment.
as per #2341 - it's breaking in the strictest sense.
I personally don't see the point in keeping an invalid schema in here. Keeping it for the just in case seems a bit silly, considering that it has been waiting for just in case for 3 years?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was a schema defining an empty object - it's an unnecessary definition, so remove it.