Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🤖 upgrade to angular v18 #775

Merged
merged 4 commits into from
Jun 22, 2024
Merged

chore: 🤖 upgrade to angular v18 #775

merged 4 commits into from
Jun 22, 2024

Conversation

chimurai
Copy link
Contributor

@chimurai chimurai commented Jun 21, 2024 •
edited
Loading

(new PR without npm install --force)

  • Upgraded Nx incrementally between major Nx versions.
  • See commit body for details

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: Angular version update

What is the current behavior?

Angular 17

Issue Number: N/A

What is the new behavior?

Angular 18

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@chimurai chimurai mentioned this pull request Jun 21, 2024
Closed
13 tasks
@shaharkazaz
Copy link
Collaborator

Why is this marked as a breaking change? Nothing is actually affected

@chimurai
Copy link
Contributor Author

You're right.
Removed the "breaking change" from commit body and PR description

@shaharkazaz
Copy link
Collaborator

I ran yesterday the upgrade as well, but I did nx 17 -> 18 -> 19 instead of the latest directly, and I didn't get all these changes in the project.json files which makes me wonder which version is the correct one and why I didn't get those changes.
I ran the migrations between each step of course.
Any idea?

@chimurai
Copy link
Contributor Author

chimurai commented Jun 22, 2024 •
edited
Loading

Hmmm... Indeed, I don't see project.json changes with intermediate upgrades.

Found Nx's recommendation on upgrades:

One major version at a time, small steps
https://nx.dev/recipes/tips-n-tricks/advanced-update#recommendations

I'll revert the commits and rebase this branch with intermediate upgrades 👍

@shaharkazaz
Copy link
Collaborator

shaharkazaz commented Jun 22, 2024 •
edited
Loading

Yep, that's what I did 😄
It's a good practice in general

chimurai added 4 commits June 22, 2024 17:45
@chimurai
chore: 🤖 upgrade to nx v18
32fe775 
- npx nx migrate 18
- npx nx migrate @angular/cli@17
- npm run migrate
- npm i -D @jscutlery/semver@latest --save-exact
- npm i -D postcss@latest --save-exact
@chimurai
chore: 🤖 upgrade to nx v19
dda3d9c 
- npx nx migrate 19
- npx nx migrate @angular/cli@18
- npm run migrate
- fix: Invalid self-closing element in index HTML file: '<app-root />'.
@chimurai
chore: 🤖 upgrade to @ngneat/spectator v19
562c4bd 
npm i -D @ngneat/spectator@latest --save-exact
@chimurai
chore: 🤖 npm audit fix
e7ff330 
fix: 13 vulnerabilities (9 moderate, 4 high)
@chimurai
Copy link
Contributor Author

Much better now without project.json changes 😄

@shaharkazaz shaharkazaz merged commit 7a11061 into jsverse:master Jun 22, 2024
5 checks passed
@chimurai chimurai deleted the ng-18.0.4 branch June 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chimurai @shaharkazaz