Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 upgrade to angular v18 #773

Closed
wants to merge 3 commits into from
Closed

Conversation

chimurai
Copy link
Contributor

BREAKING CHANGE: 🧨 Angular 18

  • npm run update
  • npm install --force
  • npm run migrate
  • fix: Invalid self-closing element in index HTML file: '<app-root />'.
  • npm i -D @jscutlery/semver@latest --save-exact
  • bump @ngneat/spectator to v19
  • npm audit fix (15 vulnerabilities (11 moderate, 4 high))

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Angular 17

Issue Number: N/A

What is the new behavior?

Angular 18

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

closes: #734

chimurai added 3 commits June 19, 2024 20:59
BREAKING CHANGE: 🧨 Angular 18

- npm run update
- npm install --force
- npm run migrate
- fix: Invalid self-closing element in index HTML file: '<app-root />'.
- npm i -D @jscutlery/semver@latest --save-exact
15 vulnerabilities (11 moderate, 4 high)
@shaharkazaz
Copy link
Collaborator

@chimurai Thanks for the PR! why we need to force install?

@chimurai
Copy link
Contributor Author

chimurai commented Jun 20, 2024

That was due to dependency conflicts after npm run update and npm install:

image

Happy to hear if there is a better way.

@shaharkazaz
Copy link
Collaborator

shaharkazaz commented Jun 21, 2024

@chimurai The solution is to resolve the conflicts 🙂
I'll give it a go locally to see what's up

@chimurai
Copy link
Contributor Author

chimurai commented Jun 21, 2024

Found the issue.
Bit confusing message from nx after running npm run update
Running npm install caused all the dependency conflict messages.

image

npm install or npm install --force is not needed when running these two commands sequentially:

npm run update
npm run migrate

Will open a new PR without npm install --force

@chimurai
Copy link
Contributor Author

new PR without npm install --force: #775

@chimurai chimurai closed this Jun 21, 2024
@chimurai chimurai deleted the ng18 branch June 22, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants