-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api: URL Pattern API implementation #136
Conversation
74cf659
to
bdaa18a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Some minor nits to fix
Thanks for the review! Tried to address all of the comments. |
LGTM! 🎉 I made a review commit to:
This PR is ready to be merged, but I'd prefer to hold off on merging it until our testing infrastructure is done. Also before merging please tidy up the git history (either by squashing or rebasing and rewriting history) |
4a5af61
to
71f9f44
Compare
@erivas-ligo are wpt tests enabled? If not, then this PR will be stuck until so |
0861f1f
to
dd79003
Compare
dd79003
to
e261e02
Compare
Description
Related issue: 🚧 API: URLPattern #100
Dependencies: urlpattern
This PR uses
urlpattern
crate (which was created by Deno developers) to implementURLPattern
.The underlying crate, and thus
URLPattern
as defined here (and also Deno) has difference with the URL Pattern specified: it does not support theignoreCase
option. There is an open PR inurlpattern
to support it, but it is already quite old, and not sure if it will be supported.A single
NativeClass
is introduced (forURLPattern
). For the other components (URLPatternInit
,URLPatternInput
,URLPatternComponentResult
,URLPatternResult
) this PR does not introduce native classes, and instead uses neededTryFromJs
andIntoJs
implementations.Manual testing
Testing
Checklist
make fmt-check
to check)